diff --git a/ChangeLog b/ChangeLog index 7d25515472..293371ad3c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2006-05-18 Tim-Philipp Müller + + * gst/subparse/samiparse.c: (handle_start_font): + Don't ignore return value of strtol (++compiler_happiness). + 2006-05-17 Tim-Philipp Müller Patch by: Young-Ho Cha diff --git a/gst/subparse/samiparse.c b/gst/subparse/samiparse.c index b3906c0990..dede935fcd 100644 --- a/gst/subparse/samiparse.c +++ b/gst/subparse/samiparse.c @@ -168,8 +168,9 @@ handle_start_font (GstSamiContext * sctx, const xmlChar ** atts) if (!(*value == '#' && len == 7)) { gchar *r; - strtol ((const char *) value, &r, 16); /* trying onvert hex */ - if (((xmlChar *) r == (value + 6) && len == 6)) { + /* check if it looks like hex */ + if (strtol ((const char *) value, &r, 16) >= 0 && + ((xmlChar *) r == (value + 6) && len == 6)) { sharp = "#"; } }