From 31ccb3106fc81f4134fdebccb775fccf01fbdaff Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Fri, 7 Jun 2019 16:06:39 -0400 Subject: [PATCH] timeline: Do not post upstream translated composition update messages In the case of nested timeline in the toplevel timeline we ended up with CompositionUpdate for seeks sent by our own composition to granchildren composition. This was not causing essential issues if all tracks where containing nested timelines but in cases where one of the tracks only had a nested timelines, then we were waiting forever for a `CompositionUpdateDone`. CompositionUpdate translated into ASYNC_START/ASYNC_DONE should be kept inside the GESTimeline and not travel up (possibly to some parent GESTimeline). --- ges/ges-timeline.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ges/ges-timeline.c b/ges/ges-timeline.c index f2fd6163c5..ca8e67e309 100644 --- a/ges/ges-timeline.c +++ b/ges/ges-timeline.c @@ -370,8 +370,10 @@ ges_timeline_handle_message (GstBin * bin, GstMessage * message) GST_OBJECT_UNLOCK (timeline); } - if (amessage) + if (amessage) { gst_element_post_message (GST_ELEMENT_CAST (bin), amessage); + return; + } } forward: