From 307018da8926a943ff93b7f32ffe32be930dd7ea Mon Sep 17 00:00:00 2001 From: Nicolas Dufresne Date: Sat, 23 Sep 2017 15:44:09 -0400 Subject: [PATCH] flvdemux: Don't pull passed the EOS When a truncated FLV is provided and processed in pull mode, we may endup trying to pull passed EOS, causing a rather confusing warning as the pull offset is an integer overflow. https://bugzilla.gnome.org/show_bug.cgi?id=787795 --- gst/flv/gstflvdemux.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gst/flv/gstflvdemux.c b/gst/flv/gstflvdemux.c index 2ac868b629..4fc2bad62e 100644 --- a/gst/flv/gstflvdemux.c +++ b/gst/flv/gstflvdemux.c @@ -2570,6 +2570,9 @@ gst_flv_demux_get_metadata (GstFlvDemux * demux) gst_buffer_unref (buffer); buffer = NULL; + if (G_UNLIKELY (offset < tag_size)) + goto exit; + offset -= tag_size; if (GST_FLOW_OK != gst_flv_demux_pull_range (demux, demux->sinkpad, offset, 12, &buffer))