From 2fd2af94209299fa49cf998a0198a6b60878276a Mon Sep 17 00:00:00 2001 From: Mathieu Duponchelle Date: Wed, 15 Feb 2023 15:33:39 +0100 Subject: [PATCH] ges-source: do not emit no-more-pads on child element This most likely never caused any issues as we don't connect to no-more-pads in the first place, and the element isn't directly exposed to the user, but emitting it makes no sense, and we are actually going to connect to no-more-pads in a subsequent commit. The call was added in 86b893e54cadde01e025e5876fa666f5d889f9ea, a patch by me in 2013, I have no idea why but I probably didn't have a firm grasp on what I was doing then. Part-of: --- subprojects/gst-editing-services/ges/ges-source.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/subprojects/gst-editing-services/ges/ges-source.c b/subprojects/gst-editing-services/ges/ges-source.c index 738686011b..43b5f42707 100644 --- a/subprojects/gst-editing-services/ges/ges-source.c +++ b/subprojects/gst-editing-services/ges/ges-source.c @@ -131,8 +131,6 @@ _set_ghost_pad_target (GESSource * self, GstPad * srcpad, GstElement * element) if (!gst_ghost_pad_set_target (GST_GHOST_PAD (priv->ghostpad), srcpad)) GST_ERROR_OBJECT (self, "Could not set ghost target"); } - - gst_element_no_more_pads (element); } /* @elements: (transfer-full) */