From 2d2a3c6ae137c45e3ac3e3a5b4f5f86881e1c370 Mon Sep 17 00:00:00 2001 From: Ruben Gonzalez Date: Mon, 21 Feb 2022 23:29:23 +0100 Subject: [PATCH] x264enc: Update long-name and description Update x264enc long-name to be more than just the name. Then the description also was updated to be longer than the long-name, and similar to the plugin description. Finally, as I am here, H264 was replaced by H.264 and x264 is only a plugin (not plugins). Part-of: --- subprojects/gst-plugins-ugly/docs/gst_plugins_cache.json | 6 +++--- subprojects/gst-plugins-ugly/ext/x264/gstx264enc.c | 7 ++++--- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/subprojects/gst-plugins-ugly/docs/gst_plugins_cache.json b/subprojects/gst-plugins-ugly/docs/gst_plugins_cache.json index e3290a1a92..1de6d70dbd 100644 --- a/subprojects/gst-plugins-ugly/docs/gst_plugins_cache.json +++ b/subprojects/gst-plugins-ugly/docs/gst_plugins_cache.json @@ -1178,11 +1178,11 @@ "url": "Unknown package origin" }, "x264": { - "description": "libx264-based H264 plugins", + "description": "libx264-based H.264 encoder plugin", "elements": { "x264enc": { "author": "Josef Zlomek , Mark Nauwelaerts ", - "description": "H264 Encoder", + "description": "libx264-based H.264 video encoder", "hierarchy": [ "GstX264Enc", "GstVideoEncoder", @@ -1195,7 +1195,7 @@ "GstPreset" ], "klass": "Codec/Encoder/Video", - "long-name": "x264enc", + "long-name": "x264 H.264 Encoder", "pad-templates": { "sink": { "caps": "video/x-raw:\n framerate: [ 0/1, 2147483647/1 ]\n width: [ 1, 2147483647 ]\n height: [ 1, 2147483647 ]\n format: { Y444, Y42B, I420, YV12, NV12, Y444_10LE, I422_10LE, I420_10LE }\n", diff --git a/subprojects/gst-plugins-ugly/ext/x264/gstx264enc.c b/subprojects/gst-plugins-ugly/ext/x264/gstx264enc.c index 2604506f17..70f73c519f 100644 --- a/subprojects/gst-plugins-ugly/ext/x264/gstx264enc.c +++ b/subprojects/gst-plugins-ugly/ext/x264/gstx264enc.c @@ -86,7 +86,7 @@ * |[ * gst-launch-1.0 -v videotestsrc num-buffers=1000 ! tee name=t ! queue ! videoconvert ! autovideosink \ * t. ! queue ! x264enc rc-lookahead=5 ! fakesink - * ]| This example pipeline will encode a test video source to H264 while + * ]| This example pipeline will encode a test video source to H.264 while * displaying the input material at the same time. As mentioned above, * specific settings are needed in this case to avoid pipeline stalling. * Depending on goals and context, other approaches are possible, e.g. @@ -1199,7 +1199,8 @@ gst_x264_enc_class_init (GstX264EncClass * klass) g_string_append_printf (x264enc_defaults, ":weightp=0"); gst_element_class_set_static_metadata (element_class, - "x264enc", "Codec/Encoder/Video", "H264 Encoder", + "x264 H.264 Encoder", "Codec/Encoder/Video", + "libx264-based H.264 video encoder", "Josef Zlomek , " "Mark Nauwelaerts "); @@ -3053,5 +3054,5 @@ plugin_init (GstPlugin * plugin) GST_PLUGIN_DEFINE (GST_VERSION_MAJOR, GST_VERSION_MINOR, x264, - "libx264-based H264 plugins", + "libx264-based H.264 encoder plugin", plugin_init, VERSION, "GPL", GST_PACKAGE_NAME, GST_PACKAGE_ORIGIN)