From 2c54ea5ba9831e8de45a47896a9076a245be2c70 Mon Sep 17 00:00:00 2001 From: Luis de Bethencourt Date: Wed, 16 Dec 2015 11:43:58 +0000 Subject: [PATCH] dv1394: log error if failed to set socket status flag Log an error message if failed to set write or read socket as non-blocking. CID 1139608 CID 1139609 --- ext/raw1394/gstdv1394src.c | 8 ++++++-- ext/raw1394/gsthdv1394src.c | 8 ++++++-- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ext/raw1394/gstdv1394src.c b/ext/raw1394/gstdv1394src.c index 09755ba53b..dbc7607268 100644 --- a/ext/raw1394/gstdv1394src.c +++ b/ext/raw1394/gstdv1394src.c @@ -790,8 +790,12 @@ gst_dv1394src_start (GstBaseSrc * bsrc) READ_SOCKET (src) = control_sock[0]; WRITE_SOCKET (src) = control_sock[1]; - fcntl (READ_SOCKET (src), F_SETFL, O_NONBLOCK); - fcntl (WRITE_SOCKET (src), F_SETFL, O_NONBLOCK); + if (fcntl (READ_SOCKET (src), F_SETFL, O_NONBLOCK) < 0) + GST_ERROR_OBJECT (src, "failed to make read socket non-blocking: %s", + g_strerror (errno)); + if (fcntl (WRITE_SOCKET (src), F_SETFL, O_NONBLOCK) < 0) + GST_ERROR_OBJECT (src, "failed to make write socket non-blocking: %s", + g_strerror (errno)); src->handle = raw1394_new_handle (); diff --git a/ext/raw1394/gsthdv1394src.c b/ext/raw1394/gsthdv1394src.c index f81f70f9db..0b07a3723f 100644 --- a/ext/raw1394/gsthdv1394src.c +++ b/ext/raw1394/gsthdv1394src.c @@ -527,8 +527,12 @@ gst_hdv1394src_start (GstBaseSrc * bsrc) READ_SOCKET (src) = control_sock[0]; WRITE_SOCKET (src) = control_sock[1]; - fcntl (READ_SOCKET (src), F_SETFL, O_NONBLOCK); - fcntl (WRITE_SOCKET (src), F_SETFL, O_NONBLOCK); + if (fcntl (READ_SOCKET (src), F_SETFL, O_NONBLOCK) < 0) + GST_ERROR_OBJECT (src, "failed to make read socket non-blocking: %s", + g_strerror (errno)); + if (fcntl (WRITE_SOCKET (src), F_SETFL, O_NONBLOCK) < 0) + GST_ERROR_OBJECT (src, "failed to make write socket non-blocking: %s", + g_strerror (errno)); src->handle = raw1394_new_handle ();