From 288e8d5c0ed21e11f5aa8e0dcb50f1f1ac584108 Mon Sep 17 00:00:00 2001 From: Thiago Santos Date: Tue, 13 May 2014 10:24:51 -0300 Subject: [PATCH] dashdemux: mpdparser: avoid double free of segment timeline node The parsing function already frees the old value (if any), avoid a double free by not freeing it before calling the function without setting the pointer to NULL Coverity ID: 1212178 --- ext/dash/gstmpdparser.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/ext/dash/gstmpdparser.c b/ext/dash/gstmpdparser.c index cc13ce9803..a6f12f1085 100644 --- a/ext/dash/gstmpdparser.c +++ b/ext/dash/gstmpdparser.c @@ -1357,10 +1357,7 @@ gst_mpdparser_parse_mult_seg_base_type_ext (GstMultSegmentBaseType ** pointer, for (cur_node = a_node->children; cur_node; cur_node = cur_node->next) { if (cur_node->type == XML_ELEMENT_NODE) { if (xmlStrcmp (cur_node->name, (xmlChar *) "SegmentTimeline") == 0) { - if (mult_seg_base_type->SegmentTimeline) { - gst_mpdparser_free_segment_timeline_node - (mult_seg_base_type->SegmentTimeline); - } + /* parse frees the segmenttimeline if any */ gst_mpdparser_parse_segment_timeline_node (&mult_seg_base_type->SegmentTimeline, cur_node); } else if (xmlStrcmp (cur_node->name,