From 28775dad59392679e6ef07be6a1cfd4f18b400f7 Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Sun, 22 Sep 2013 21:56:14 +0200 Subject: [PATCH] tests: Make sure not to test freed objects type --- tests/check/ges/clip.c | 1 - tests/check/ges/layer.c | 4 +++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/check/ges/clip.c b/tests/check/ges/clip.c index dab49891aa..bd6524673d 100644 --- a/tests/check/ges/clip.c +++ b/tests/check/ges/clip.c @@ -349,7 +349,6 @@ GST_START_TEST (test_clip_refcount_remove_child) fail_unless (ges_container_remove (GES_CONTAINER (clip), GES_TIMELINE_ELEMENT (effect))); fail_unless (called == TRUE); - fail_if (G_IS_OBJECT (effect)); check_destroyed (G_OBJECT (track), NULL, NULL); check_destroyed (G_OBJECT (clip), NULL, NULL); diff --git a/tests/check/ges/layer.c b/tests/check/ges/layer.c index dfe21a7329..6721b92ad6 100644 --- a/tests/check/ges/layer.c +++ b/tests/check/ges/layer.c @@ -610,6 +610,8 @@ GST_START_TEST (test_single_layer_automatic_transition) g_list_free_full (objects, gst_object_unref); GST_DEBUG ("Back to previous state"); + /* Make sure to keep 1 ref so we can check_destroyed afterward */ + gst_object_ref (transition); ges_timeline_element_set_duration (src, 1100 - 600); /* 600____src___1100 * 500___________src1________1250 @@ -623,7 +625,7 @@ GST_START_TEST (test_single_layer_automatic_transition) assert_equals_uint64 (_DURATION (src2), 1000); /* We check that the transition as actually been freed */ - fail_if (GES_IS_TRANSITION_CLIP (transition)); + check_destroyed (G_OBJECT (transition), NULL, NULL); objects = ges_layer_get_clips (layer); assert_equals_int (g_list_length (objects), 3);