From 2541a33d6c3fccc4bf0f3bcb09dcb28062280dbe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Manuel=20J=C3=A1quez=20Leal?= Date: Fri, 3 May 2019 10:31:52 +0200 Subject: [PATCH] libs: encoder: continue if roi meta is NULL Coverity scan bug: If the function actually returns a null value, a null pointer dereference will occur. In gst_vaapi_encoder_ensure_param_roi_regions(): Return value of function which returns null is dereferenced without checking --- gst-libs/gst/vaapi/gstvaapiencoder.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gst-libs/gst/vaapi/gstvaapiencoder.c b/gst-libs/gst/vaapi/gstvaapiencoder.c index 62f4099a66..59f3cb6edf 100644 --- a/gst-libs/gst/vaapi/gstvaapiencoder.c +++ b/gst-libs/gst/vaapi/gstvaapiencoder.c @@ -329,6 +329,8 @@ gst_vaapi_encoder_ensure_param_roi_regions (GstVaapiEncoder * encoder, roi = (GstVideoRegionOfInterestMeta *) gst_buffer_iterate_meta_filtered (input, &state, GST_VIDEO_REGION_OF_INTEREST_META_API_TYPE); + if (!roi) + continue; /* ignore roi if overflow */ if ((roi->x > G_MAXINT16) || (roi->y > G_MAXINT16)