From 2505ab17e98eb6343ceae0e6fb7e130a90ec34f0 Mon Sep 17 00:00:00 2001
From: He Junyan <junyan.he@intel.com>
Date: Fri, 6 Aug 2021 17:11:55 +0800
Subject: [PATCH] va: caps: Make the template raw video caps classified by
 features.

The current output of raw video caps is not good. When we have multi
profiles and each profile support different formats, the output of
gst-inspect may like:

 SRC template: 'src'
 Availability: Always
 Capabilities:
   video/x-raw(memory:VAMemory)
         width: [ 1, 16384 ]
         height: [ 1, 16384 ]
         format: NV12
   video/x-raw
         width: [ 1, 16384 ]
         height: [ 1, 16384 ]
         format: NV12
   video/x-raw(memory:VAMemory)
         width: [ 1, 16384 ]
         height: [ 1, 16384 ]
         format: P010_10LE
   video/x-raw
         width: [ 1, 16384 ]
         height: [ 1, 16384 ]
         format: P010_10LE
   video/x-raw(memory:VAMemory)
         width: [ 1, 16384 ]
         height: [ 1, 16384 ]
         format: P012_LE
   video/x-raw
         width: [ 1, 16384 ]
         height: [ 1, 16384 ]
         format: P012_LE

The gst_caps_simplify does not classify the caps by same features, but
just leave them interweaved. We need to handle them manually here, the
result should be:

  SRC template: 'src'
  Availability: Always
  Capabilities:
    video/x-raw
          width: [ 1, 16384 ]
          height: [ 1, 16384 ]
          format: { (string)P010_10LE, (string)P012_LE, (string)NV12 }
    video/x-raw(memory:VAMemory)
          width: [ 1, 16384 ]
          height: [ 1, 16384 ]
          format: { (string)P010_10LE, (string)P012_LE, (string)NV12 }

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/2456>
---
 sys/va/gstvacaps.c | 45 ++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 44 insertions(+), 1 deletion(-)

diff --git a/sys/va/gstvacaps.c b/sys/va/gstvacaps.c
index 1b0dd651c4..181c8d7a3f 100644
--- a/sys/va/gstvacaps.c
+++ b/sys/va/gstvacaps.c
@@ -385,6 +385,49 @@ gst_va_create_coded_caps (GstVaDisplay * display, VAProfile profile,
   return caps;
 }
 
+static GstCaps *
+_regroup_raw_caps (GstCaps * caps)
+{
+  GstCaps *sys_caps, *va_caps, *dma_caps, *tmp;
+  guint size, i;
+
+  if (gst_caps_is_any (caps) || gst_caps_is_empty (caps))
+    return caps;
+
+  size = gst_caps_get_size (caps);
+  if (size <= 1)
+    return caps;
+
+  /* We need to simplify caps by features. */
+  sys_caps = gst_caps_new_empty ();
+  va_caps = gst_caps_new_empty ();
+  dma_caps = gst_caps_new_empty ();
+  for (i = 0; i < size; i++) {
+    GstCapsFeatures *ft;
+
+    tmp = gst_caps_copy_nth (caps, i);
+    ft = gst_caps_get_features (tmp, 0);
+    if (gst_caps_features_contains (ft, GST_CAPS_FEATURE_MEMORY_DMABUF)) {
+      dma_caps = gst_caps_merge (dma_caps, tmp);
+    } else if (gst_caps_features_contains (ft, "memory:VAMemory")) {
+      va_caps = gst_caps_merge (va_caps, tmp);
+    } else {
+      sys_caps = gst_caps_merge (sys_caps, tmp);
+    }
+  }
+
+  sys_caps = gst_caps_simplify (sys_caps);
+  va_caps = gst_caps_simplify (va_caps);
+  dma_caps = gst_caps_simplify (dma_caps);
+
+  sys_caps = gst_caps_merge (sys_caps, va_caps);
+  sys_caps = gst_caps_merge (sys_caps, dma_caps);
+
+  gst_caps_unref (caps);
+
+  return sys_caps;
+}
+
 gboolean
 gst_va_caps_from_profiles (GstVaDisplay * display, GArray * profiles,
     VAEntrypoint entrypoint, GstCaps ** codedcaps_ptr, GstCaps ** rawcaps_ptr)
@@ -472,7 +515,7 @@ gst_va_caps_from_profiles (GstVaDisplay * display, GArray * profiles,
     gst_caps_replace (&codedcaps, NULL);
 
   if ((ret = codedcaps && rawcaps)) {
-    rawcaps = gst_caps_simplify (rawcaps);
+    rawcaps = _regroup_raw_caps (rawcaps);
     codedcaps = gst_caps_simplify (codedcaps);
 
     if (rawcaps_ptr)