From 24f30b2e6e55abedc22e4d9dc8dea44eb9c20a80 Mon Sep 17 00:00:00 2001
From: Seungha Yang <seungha@centricular.com>
Date: Sat, 16 May 2020 21:52:59 +0900
Subject: [PATCH] d3d11convert: Fix fallback texture setup when resolution is
 not even number

When texture format is semi-planar, resolution should be even number,
and add missing P016 format handling

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/-/merge_requests/1275>
---
 sys/d3d11/gstd3d11colorconvert.c | 52 ++++++++++++++++++++++++++++----
 sys/d3d11/gstd3d11colorconvert.h |  4 +++
 2 files changed, 50 insertions(+), 6 deletions(-)

diff --git a/sys/d3d11/gstd3d11colorconvert.c b/sys/d3d11/gstd3d11colorconvert.c
index 5cd29abfe8..5893352e90 100644
--- a/sys/d3d11/gstd3d11colorconvert.c
+++ b/sys/d3d11/gstd3d11colorconvert.c
@@ -1170,10 +1170,23 @@ create_shader_input_resource (GstD3D11ColorConvert * self,
       }
     }
   } else {
+    gboolean is_semiplanar = FALSE;
+
+    if (format->dxgi_format == DXGI_FORMAT_NV12 ||
+        format->dxgi_format == DXGI_FORMAT_P010 ||
+        format->dxgi_format == DXGI_FORMAT_P016)
+      is_semiplanar = TRUE;
+
     texture_desc.Width = GST_VIDEO_INFO_WIDTH (info);
     texture_desc.Height = GST_VIDEO_INFO_HEIGHT (info);
     texture_desc.Format = format->dxgi_format;
 
+    /* semiplanar format resolution of should be even number */
+    if (is_semiplanar) {
+      texture_desc.Width = GST_ROUND_UP_2 (texture_desc.Width);
+      texture_desc.Height = GST_ROUND_UP_2 (texture_desc.Height);
+    }
+
     hr = ID3D11Device_CreateTexture2D (device_handle,
         &texture_desc, NULL, &tex[0]);
     if (!gst_d3d11_result (hr, device)) {
@@ -1181,8 +1194,7 @@ create_shader_input_resource (GstD3D11ColorConvert * self,
       goto error;
     }
 
-    if (format->dxgi_format == DXGI_FORMAT_NV12 ||
-        format->dxgi_format == DXGI_FORMAT_P010) {
+    if (is_semiplanar) {
       ID3D11Resource_AddRef (tex[0]);
       tex[1] = tex[0];
     }
@@ -1274,10 +1286,23 @@ create_shader_output_resource (GstD3D11ColorConvert * self,
       }
     }
   } else {
+    gboolean is_semiplanar = FALSE;
+
+    if (format->dxgi_format == DXGI_FORMAT_NV12 ||
+        format->dxgi_format == DXGI_FORMAT_P010 ||
+        format->dxgi_format == DXGI_FORMAT_P016)
+      is_semiplanar = TRUE;
+
     texture_desc.Width = GST_VIDEO_INFO_WIDTH (info);
     texture_desc.Height = GST_VIDEO_INFO_HEIGHT (info);
     texture_desc.Format = format->dxgi_format;
 
+    /* semiplanar format resolution of should be even number */
+    if (is_semiplanar) {
+      texture_desc.Width = GST_ROUND_UP_2 (texture_desc.Width);
+      texture_desc.Height = GST_ROUND_UP_2 (texture_desc.Height);
+    }
+
     hr = ID3D11Device_CreateTexture2D (device_handle,
         &texture_desc, NULL, &tex[0]);
     if (!gst_d3d11_result (hr, device)) {
@@ -1285,8 +1310,7 @@ create_shader_output_resource (GstD3D11ColorConvert * self,
       goto error;
     }
 
-    if (format->dxgi_format == DXGI_FORMAT_NV12 ||
-        format->dxgi_format == DXGI_FORMAT_P010) {
+    if (is_semiplanar) {
       ID3D11Resource_AddRef (tex[0]);
       tex[1] = tex[0];
     }
@@ -1385,6 +1409,21 @@ gst_d3d11_color_convert_set_info (GstD3D11BaseFilter * filter,
     return FALSE;
   }
 
+  /* setup D3D11_BOX struct for fallback copy */
+  self->in_src_box.left = 0;
+  self->in_src_box.top = 0;
+  self->in_src_box.front = 0;
+  self->in_src_box.back = 1;
+  self->in_src_box.right = GST_VIDEO_INFO_WIDTH (in_info);
+  self->in_src_box.bottom = GST_VIDEO_INFO_HEIGHT (in_info);
+
+  self->out_src_box.left = 0;
+  self->out_src_box.top = 0;
+  self->out_src_box.front = 0;
+  self->out_src_box.back = 1;
+  self->out_src_box.right = GST_VIDEO_INFO_WIDTH (out_info);
+  self->out_src_box.bottom = GST_VIDEO_INFO_HEIGHT (out_info);
+
   return TRUE;
 
   /* ERRORS */
@@ -1468,7 +1507,7 @@ gst_d3d11_color_convert_transform (GstBaseTransform * trans,
       ID3D11DeviceContext_CopySubresourceRegion (context_handle,
           (ID3D11Resource *) self->in_texture[i], 0, 0, 0, 0,
           (ID3D11Resource *) d3d11_mem->texture, d3d11_mem->subresource_index,
-          NULL);
+          &self->in_src_box);
     }
     gst_d3d11_device_unlock (device);
   }
@@ -1522,7 +1561,8 @@ gst_d3d11_color_convert_transform (GstBaseTransform * trans,
 
       ID3D11DeviceContext_CopySubresourceRegion (context_handle,
           (ID3D11Resource *) d3d11_mem->texture, d3d11_mem->subresource_index,
-          0, 0, 0, (ID3D11Resource *) self->out_texture[i], 0, NULL);
+          0, 0, 0, (ID3D11Resource *) self->out_texture[i], 0,
+          &self->out_src_box);
     }
     gst_d3d11_device_unlock (device);
   } else {
diff --git a/sys/d3d11/gstd3d11colorconvert.h b/sys/d3d11/gstd3d11colorconvert.h
index 4bb89feed0..52fa883466 100644
--- a/sys/d3d11/gstd3d11colorconvert.h
+++ b/sys/d3d11/gstd3d11colorconvert.h
@@ -50,6 +50,10 @@ struct _GstD3D11ColorConvert
   guint num_output_view;
 
   GstD3D11ColorConverter *converter;
+
+  /* used for fallback texture copy */
+  D3D11_BOX in_src_box;
+  D3D11_BOX out_src_box;
 };
 
 struct _GstD3D11ColorConvertClass