From 219bf891595d85e9119e1efdcbfc91414052c08f Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Tue, 17 Dec 2024 17:36:19 +0100 Subject: [PATCH] wpe: enable console message with WPE2 Looks like the WebKitConsoleMessage API is now available in WPE2 as well: https://webkitgtk.org/reference/webkitgtk-web-process-extension/stable/signal.WebPage.console-message-sent.html Part-of: --- .../gst-plugins-bad/ext/wpe/wpe-extension/gstwpeextension.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/subprojects/gst-plugins-bad/ext/wpe/wpe-extension/gstwpeextension.c b/subprojects/gst-plugins-bad/ext/wpe/wpe-extension/gstwpeextension.c index 6bba314f97..96009dddba 100644 --- a/subprojects/gst-plugins-bad/ext/wpe/wpe-extension/gstwpeextension.c +++ b/subprojects/gst-plugins-bad/ext/wpe/wpe-extension/gstwpeextension.c @@ -45,7 +45,6 @@ G_MODULE_EXPORT void extension_initialize (WebKitWebExtension * extension); static WebKitWebExtension *global_extension = NULL; -#if !USE_WPE2 static void console_message_cb (WebKitWebPage * page, WebKitConsoleMessage * console_message, gpointer data) @@ -56,17 +55,13 @@ console_message_cb (WebKitWebPage * page, NULL); g_free (message); } -#endif static void web_page_created_callback (WebKitWebExtension * extension, WebKitWebPage * web_page, gpointer data) { - // WebKitConsoleMessage is deprecated in wpe1 and has no replacement in wpe2. -#if !USE_WPE2 g_signal_connect (web_page, "console-message-sent", G_CALLBACK (console_message_cb), NULL); -#endif } void