diff --git a/ChangeLog b/ChangeLog index f60da4d210..0d28b02d39 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2005-11-03 Tim-Philipp Müller + + * docs/manual/advanced-position.xml: + Update seek example and explanations to current 0.9 API. + + * gst/elements/gsttypefindelement.c: + (gst_type_find_element_activate): + Remove FIXME comment now that the found caps + are unreffed. + 2005-11-03 Thomas Vander Stichele * gst/gstregistryxml.c: (load_feature): diff --git a/docs/manual/advanced-position.xml b/docs/manual/advanced-position.xml index eaea228551..195876033b 100644 --- a/docs/manual/advanced-position.xml +++ b/docs/manual/advanced-position.xml @@ -25,8 +25,9 @@ frames or bytes. The function most commonly used for this is gst_element_query (), although some convenience wrappers are provided as well (such as - gst_element_query_position ()). You can generally - query the pipeline directly, it'll figure out the internal details + gst_element_query_position () and + gst_element_query_duration ()). You can generally + query the pipeline directly, and it'll figure out the internal details for you, like which element to query. @@ -42,12 +43,12 @@ #include <gst/gst.h> @@ -81,7 +79,8 @@ cb_print_position (GstElement *pipeline) GstFormat fmt = GST_FORMAT_TIME; gint64 pos, len; - if (gst_element_query_position (pipeline, &fmt, &pos, &len)) { + if (gst_element_query_position (pipeline, &fmt, &pos) + & & gst_element_query_duration (pipeline, &fmt, &len)) { g_print ("Time: %" GST_TIME_FORMAT " / %" GST_TIME_FORMAT "\r", GST_TIME_ARGS (pos), GST_TIME_ARGS (len)); } @@ -97,7 +96,10 @@ main (gint argc, GstElement *pipeline; [..] /* run pipeline */ @@ -149,12 +165,16 @@ main (gint argc, and it will figure out everything for you. Although there are more ways in which applications and elements can interact using events, we will only focus on seeking here. This is done using the seek-event. - A seek-event contains a seeking offset, a seek method (which indicates - relative to what the offset was given), a seek format (which is the - unit of the offset, e.g. time, audio samples, video frames or bytes) - and optionally a set of seeking-related flags (e.g. whether internal - buffers should be flushed). The behaviour of a seek is also wrapped - in the function gst_element_seek (). + A seek-event contains a playback rate, a seek offset format (which is + the unit of the offsets to follow, e.g. time, audio samples, video + frames or bytes), optionally a set of seeking-related flags (e.g. + whether internal buffers should be flushed), a seek method (which + indicates relative to what the offset was given), and seek offsets. + The first offset (cur) is the new position to seek to, while + the second offset (stop) is optional and specifies a position where + streaming is supposed to stop. Usually it is fine to just specify + GST_SEEK_TYPE_NONE and -1 as end_method and end offset. The behaviour + of a seek is also wrapped in the gst_element_seek (). @@ -162,11 +182,33 @@ static void seek_to_time (GstElement *pipeline, gint64 time_nanoseconds) { - gst_element_seek (pipeline, - GST_SEEK_METHOD_SET | GST_FORMAT_TIME | - GST_SEEK_FLAG_FLUSH, time_nanoseconds); + GstFormat format = GST_FORMAT_TIME; + + if (!gst_element_seek (pipeline, 1.0, &format, GST_SEEK_FLAG_FLUSH, + GST_SEEK_TYPE_SET, time_nanoseconds, + GST_SEEK_TYPE_NONE, GST_CLOCK_TIME_NONE)) { + g_print ("Seek failed!\n"); + } } + + Seeks should usually be done when the pipeline is in PAUSED or PLAYING + state (when it is in PLAYING state the pipeline will pause itself, issue + the seek, and then set itself back to PLAYING again itself). + returns. + + + + It is important to realise that seeks will not happen instantly in the + sense that they are finished when the function + gst_element_seek () returns. Depending on the + specific elements involved, the actual seeking might be done later in + another thread (the streaming thread), and it might take a short time + until buffers from the new seek position will reach downstream elements + such as sinks (if the seek was non-flushing then it might take a bit + longer). + + It is possible to do multiple seeks in short time-intervals, such as a direct response to slider movement. After a seek, internally, the diff --git a/gst/elements/gsttypefindelement.c b/gst/elements/gsttypefindelement.c index 4817726c6c..83f3e25550 100644 --- a/gst/elements/gsttypefindelement.c +++ b/gst/elements/gsttypefindelement.c @@ -826,7 +826,6 @@ gst_type_find_element_activate (GstPad * pad) 0, 100, found_caps); gst_caps_unref (found_caps); typefind->mode = MODE_NORMAL; - /* FIXME see if I can unref the caps here */ /* 7 */ if (gst_pad_is_active (pad)) diff --git a/plugins/elements/gsttypefindelement.c b/plugins/elements/gsttypefindelement.c index 4817726c6c..83f3e25550 100644 --- a/plugins/elements/gsttypefindelement.c +++ b/plugins/elements/gsttypefindelement.c @@ -826,7 +826,6 @@ gst_type_find_element_activate (GstPad * pad) 0, 100, found_caps); gst_caps_unref (found_caps); typefind->mode = MODE_NORMAL; - /* FIXME see if I can unref the caps here */ /* 7 */ if (gst_pad_is_active (pad))