From 1f3ef7aa018498da4c621d0dd89de459e5f14990 Mon Sep 17 00:00:00 2001 From: Thibault Saunier Date: Wed, 18 Jul 2018 21:13:57 -0400 Subject: [PATCH] basetransform: Do not check if NULL is an emtpy caps gst_base_transform_transform_caps can return NULL in various conditions thus we should not treat its result as valid caps. In all other places NULL is properly handled. --- libs/gst/base/gstbasetransform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libs/gst/base/gstbasetransform.c b/libs/gst/base/gstbasetransform.c index 9215269275..5ddad78342 100644 --- a/libs/gst/base/gstbasetransform.c +++ b/libs/gst/base/gstbasetransform.c @@ -652,7 +652,7 @@ gst_base_transform_query_caps (GstBaseTransform * trans, GstPad * pad, GST_DEBUG_OBJECT (pad, "transformed %" GST_PTR_FORMAT, peerfilter); gst_caps_unref (temp); - if (!gst_caps_is_empty (peerfilter)) { + if (peerfilter && !gst_caps_is_empty (peerfilter)) { /* and filter against the template of the other pad */ GST_DEBUG_OBJECT (pad, "our template %" GST_PTR_FORMAT, otempl); /* We keep the caps sorted like the returned caps */