From 1e974b15810ad5d53622fd35a0fc139f8c84942d Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Fri, 2 Dec 2011 12:01:22 +0000 Subject: [PATCH] v4l2src: add a comment about a "hidden" assumption on rank values https://bugzilla.gnome.org/show_bug.cgi?id=665387 --- sys/v4l2/gstv4l2object.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/v4l2/gstv4l2object.c b/sys/v4l2/gstv4l2object.c index 76ac677823..f191bc9a45 100644 --- a/sys/v4l2/gstv4l2object.c +++ b/sys/v4l2/gstv4l2object.c @@ -893,6 +893,8 @@ gst_v4l2_object_get_format_from_fourcc (GstV4l2Object * v4l2object, /* complete made up ranking, the values themselves are meaningless */ +/* These ranks MUST be X such that X<<15 fits on a signed int - see + the comment at the end of gst_v4l2_object_format_get_rank. */ #define YUV_BASE_RANK 1000 #define JPEG_BASE_RANK 500 #define DV_BASE_RANK 200