From 1e5851fa00c83332e1c08c790f56724da82157c5 Mon Sep 17 00:00:00 2001
From: Matthew Waters <ystreet00@gmail.com>
Date: Sun, 23 Feb 2014 10:36:57 +1100
Subject: [PATCH] [887/906] mixer: fixup a memory leak of the context in the
 GLTextureUploadMeta path

gst_structure_get returns a reference to the object and we asked
for another with gst_object_replace.

https://bugzilla.gnome.org/show_bug.cgi?id=724816
---
 gst-libs/gst/gl/gstglmixer.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gst-libs/gst/gl/gstglmixer.c b/gst-libs/gst/gl/gstglmixer.c
index 04989ea130..4f92ddcc99 100644
--- a/gst-libs/gst/gl/gstglmixer.c
+++ b/gst-libs/gst/gl/gstglmixer.c
@@ -1069,8 +1069,13 @@ gst_gl_mixer_decide_allocation (GstGLMixer * mix, GstQuery * query)
 
     gst_query_parse_nth_allocation_meta (query, idx, &upload_meta_params);
     if (gst_structure_get (upload_meta_params, "gst.gl.GstGLContext",
-            GST_GL_TYPE_CONTEXT, &context, NULL) && context)
-      gst_object_replace ((GstObject **) & mix->context, (GstObject *) context);
+            GST_GL_TYPE_CONTEXT, &context, NULL) && context) {
+      GstGLContext *old = mix->context;
+
+      mix->context = context;
+      if (old)
+        gst_object_unref (old);
+    }
   }
 
   if (!mix->context) {