From 195881468095c6d7904eaeac3fc3f39a57325aed Mon Sep 17 00:00:00 2001 From: Mathieu Duponchelle Date: Mon, 25 Jun 2018 14:44:58 +0200 Subject: [PATCH] webrtc-sendrecv.py: required gstreamer 1.14.2 Addresses #25 --- webrtc/README.md | 6 +----- webrtc/sendrecv/gst/webrtc-sendrecv.py | 3 ++- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/webrtc/README.md b/webrtc/README.md index 20e3488f04..0c2a006f4c 100644 --- a/webrtc/README.md +++ b/webrtc/README.md @@ -74,11 +74,7 @@ $ gcc webrtc-sendrecv.c $(pkg-config --cflags --libs gstreamer-webrtc-1.0 gstrea * python3 -m pip install --user websockets * run `python3 sendrecv/gst/webrtc-sendrecv.py ID` with the `id` from the browser. You will see state changes and an SDP exchange. -> The python version currently requires the master branches from `gst-plugins-bad` and `gst-plugins-base`. - - +> The python version requires at least version 1.14.2 of gstreamer and its plugins. With all versions, you will see a bouncing ball + hear red noise in the browser, and your browser's webcam + mic in the gst app. diff --git a/webrtc/sendrecv/gst/webrtc-sendrecv.py b/webrtc/sendrecv/gst/webrtc-sendrecv.py index 83b49ae144..083788d47b 100644 --- a/webrtc/sendrecv/gst/webrtc-sendrecv.py +++ b/webrtc/sendrecv/gst/webrtc-sendrecv.py @@ -121,7 +121,8 @@ class WebRTCClient: assert(sdp['type'] == 'answer') sdp = sdp['sdp'] print ('Received answer:\n%s' % sdp) - res, sdpmsg = GstSdp.SDPMessage.new_from_text(sdp) + res, sdpmsg = GstSdp.SDPMessage.new() + GstSdp.sdp_message_parse_buffer(bytes(sdp.encode()), sdpmsg) answer = GstWebRTC.WebRTCSessionDescription.new(GstWebRTC.WebRTCSDPType.ANSWER, sdpmsg) promise = Gst.Promise.new() self.webrtc.emit('set-remote-description', answer, promise)