diff --git a/ChangeLog b/ChangeLog index deb57b2d4b..4b4dc57664 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,14 @@ +2008-05-03 Sebastian Dröge + + * libs/gst/controller/gstcontrollerprivate.h: + * libs/gst/controller/gsthelper.c: + * libs/gst/controller/gstinterpolation.c: + * libs/gst/controller/gstinterpolationcontrolsource.c: + (gst_interpolation_control_source_set_interpolation_mode): + * libs/gst/controller/gstinterpolationcontrolsourceprivate.h: + * libs/gst/controller/lib.c: + Move some private declarations into private headers. + 2008-05-02 Sebastian Dröge * gst/gstdebugutils.c: (debug_dump_element_pad): diff --git a/libs/gst/controller/gstcontrollerprivate.h b/libs/gst/controller/gstcontrollerprivate.h index e4fafee634..ab600e92d3 100644 --- a/libs/gst/controller/gstcontrollerprivate.h +++ b/libs/gst/controller/gstcontrollerprivate.h @@ -45,6 +45,8 @@ typedef struct _GstControlledProperty #define GST_CONTROLLED_PROPERTY(obj) ((GstControlledProperty *)(obj)) +extern GQuark priv_gst_controller_key; + G_END_DECLS #endif /* __GST_CONTROLLER_PRIVATE_H__ */ diff --git a/libs/gst/controller/gsthelper.c b/libs/gst/controller/gsthelper.c index 52fda6c01a..55bacfd106 100644 --- a/libs/gst/controller/gsthelper.c +++ b/libs/gst/controller/gsthelper.c @@ -41,8 +41,6 @@ #define GST_CAT_DEFAULT controller_debug GST_DEBUG_CATEGORY_EXTERN (GST_CAT_DEFAULT); -extern GQuark priv_gst_controller_key; - /** * gst_object_control_properties: * @object: the object of which some properties should be controlled diff --git a/libs/gst/controller/gstinterpolation.c b/libs/gst/controller/gstinterpolation.c index ac32fa18f8..af536a1582 100644 --- a/libs/gst/controller/gstinterpolation.c +++ b/libs/gst/controller/gstinterpolation.c @@ -866,9 +866,8 @@ static GstInterpolateMethod interpolate_cubic = { (GstControlSourceGetValueArray) NULL }; - /* register all interpolation methods */ -GstInterpolateMethod *interpolation_methods[] = { +GstInterpolateMethod *priv_gst_interpolation_methods[] = { &interpolate_none, &interpolate_trigger, &interpolate_linear, @@ -876,4 +875,5 @@ GstInterpolateMethod *interpolation_methods[] = { &interpolate_cubic }; -guint num_interpolation_methods = G_N_ELEMENTS (interpolation_methods); +guint priv_gst_num_interpolation_methods = +G_N_ELEMENTS (priv_gst_interpolation_methods); diff --git a/libs/gst/controller/gstinterpolationcontrolsource.c b/libs/gst/controller/gstinterpolationcontrolsource.c index ad1fe119ca..da345ef9b9 100644 --- a/libs/gst/controller/gstinterpolationcontrolsource.c +++ b/libs/gst/controller/gstinterpolationcontrolsource.c @@ -44,9 +44,6 @@ #include "gstinterpolationcontrolsource.h" #include "gstinterpolationcontrolsourceprivate.h" -extern GstInterpolateMethod *interpolation_methods[]; -extern guint num_interpolation_methods; - static void gst_interpolation_control_source_init (GstInterpolationControlSource * self); static void @@ -133,7 +130,8 @@ gboolean gboolean ret = TRUE; GstControlSource *csource = GST_CONTROL_SOURCE (self); - if (mode >= num_interpolation_methods || interpolation_methods[mode] == NULL) { + if (mode >= priv_gst_num_interpolation_methods + || priv_gst_interpolation_methods[mode] == NULL) { GST_WARNING ("interpolation mode %d invalid or not implemented yet", mode); return FALSE; } @@ -151,68 +149,68 @@ gboolean g_mutex_lock (self->lock); switch (self->priv->base) { case G_TYPE_INT: - csource->get_value = interpolation_methods[mode]->get_int; + csource->get_value = priv_gst_interpolation_methods[mode]->get_int; csource->get_value_array = - interpolation_methods[mode]->get_int_value_array; + priv_gst_interpolation_methods[mode]->get_int_value_array; break; case G_TYPE_UINT:{ - csource->get_value = interpolation_methods[mode]->get_uint; + csource->get_value = priv_gst_interpolation_methods[mode]->get_uint; csource->get_value_array = - interpolation_methods[mode]->get_uint_value_array; + priv_gst_interpolation_methods[mode]->get_uint_value_array; break; } case G_TYPE_LONG:{ - csource->get_value = interpolation_methods[mode]->get_long; + csource->get_value = priv_gst_interpolation_methods[mode]->get_long; csource->get_value_array = - interpolation_methods[mode]->get_long_value_array; + priv_gst_interpolation_methods[mode]->get_long_value_array; break; } case G_TYPE_ULONG:{ - csource->get_value = interpolation_methods[mode]->get_ulong; + csource->get_value = priv_gst_interpolation_methods[mode]->get_ulong; csource->get_value_array = - interpolation_methods[mode]->get_ulong_value_array; + priv_gst_interpolation_methods[mode]->get_ulong_value_array; break; } case G_TYPE_INT64:{ - csource->get_value = interpolation_methods[mode]->get_int64; + csource->get_value = priv_gst_interpolation_methods[mode]->get_int64; csource->get_value_array = - interpolation_methods[mode]->get_int64_value_array; + priv_gst_interpolation_methods[mode]->get_int64_value_array; break; } case G_TYPE_UINT64:{ - csource->get_value = interpolation_methods[mode]->get_uint64; + csource->get_value = priv_gst_interpolation_methods[mode]->get_uint64; csource->get_value_array = - interpolation_methods[mode]->get_uint64_value_array; + priv_gst_interpolation_methods[mode]->get_uint64_value_array; break; } case G_TYPE_FLOAT:{ - csource->get_value = interpolation_methods[mode]->get_float; + csource->get_value = priv_gst_interpolation_methods[mode]->get_float; csource->get_value_array = - interpolation_methods[mode]->get_float_value_array; + priv_gst_interpolation_methods[mode]->get_float_value_array; break; } case G_TYPE_DOUBLE:{ - csource->get_value = interpolation_methods[mode]->get_double; + csource->get_value = priv_gst_interpolation_methods[mode]->get_double; csource->get_value_array = - interpolation_methods[mode]->get_double_value_array; + priv_gst_interpolation_methods[mode]->get_double_value_array; break; } case G_TYPE_BOOLEAN:{ - csource->get_value = interpolation_methods[mode]->get_boolean; + csource->get_value = priv_gst_interpolation_methods[mode]->get_boolean; csource->get_value_array = - interpolation_methods[mode]->get_boolean_value_array; + priv_gst_interpolation_methods[mode]->get_boolean_value_array; break; } case G_TYPE_ENUM:{ - csource->get_value = interpolation_methods[mode]->get_enum; + csource->get_value = priv_gst_interpolation_methods[mode]->get_enum; csource->get_value_array = - interpolation_methods[mode]->get_enum_value_array; + priv_gst_interpolation_methods[mode]->get_enum_value_array; break; } case G_TYPE_STRING:{ - csource->get_value = interpolation_methods[mode]->get_string; + csource->get_value = priv_gst_interpolation_methods[mode]->get_string; csource->get_value_array = - interpolation_methods[mode]->get_string_value_array; + priv_gst_interpolation_methods[mode]->get_string_value_array; break; } default: diff --git a/libs/gst/controller/gstinterpolationcontrolsourceprivate.h b/libs/gst/controller/gstinterpolationcontrolsourceprivate.h index 5258d56d4d..64f510e945 100644 --- a/libs/gst/controller/gstinterpolationcontrolsourceprivate.h +++ b/libs/gst/controller/gstinterpolationcontrolsourceprivate.h @@ -96,5 +96,8 @@ struct _GstInterpolationControlSourcePrivate gboolean valid_cache; }; +extern GstInterpolateMethod *priv_gst_interpolation_methods[]; +extern guint priv_gst_num_interpolation_methods; + #endif /* __GST_INTERPOLATION_CONTROL_SOURCE_PRIVATE_H__ */ diff --git a/libs/gst/controller/lib.c b/libs/gst/controller/lib.c index 3444e753b0..d81185f90a 100644 --- a/libs/gst/controller/lib.c +++ b/libs/gst/controller/lib.c @@ -24,6 +24,7 @@ # include "config.h" #endif #include +#include /* library initialisation */