From 1858853bf290bcb9866f5c960846e1146419162e Mon Sep 17 00:00:00 2001 From: Jimmy Ohn Date: Mon, 1 Apr 2019 21:49:19 +0900 Subject: [PATCH] codecanalyzer: Use glib variant of strcmp safer, and avoids missing include --- codecanalyzer/src/codecanalyzer.c | 4 ++-- codecanalyzer/src/gst_analyzer.c | 2 +- codecanalyzer/src/plugins/gst/analyzersink/gstanalyzersink.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/codecanalyzer/src/codecanalyzer.c b/codecanalyzer/src/codecanalyzer.c index a835876714..1bf43e0890 100644 --- a/codecanalyzer/src/codecanalyzer.c +++ b/codecanalyzer/src/codecanalyzer.c @@ -221,7 +221,7 @@ populate_notebook (gpointer data, gpointer user_data) notebook = (GtkWidget *) user_data; header_name = (gchar *) data; - if (strcmp (header_name, "comment")) { + if (g_strcmp0 (header_name, "comment")) { header = gtk_label_new (header_name); gtk_label_set_text (GTK_LABEL (header), header_name); @@ -304,7 +304,7 @@ callback_button_box_click (GtkWidget * widget, GdkEvent * event, header_list = analyzer_get_list_header_strings (xml_name); while (header_list) { - if (strcmp (header_list->data, "comment")) { + if (g_strcmp0 (header_list->data, "comment")) { if (is_header && !g_str_has_prefix (header_list->data, "slice")) hlist = g_list_append (hlist, header_list->data); else if (is_slice && g_str_has_prefix (header_list->data, "slice")) diff --git a/codecanalyzer/src/gst_analyzer.c b/codecanalyzer/src/gst_analyzer.c index f5fee9bf33..53172ffcfe 100644 --- a/codecanalyzer/src/gst_analyzer.c +++ b/codecanalyzer/src/gst_analyzer.c @@ -310,7 +310,7 @@ gst_analyzer_init (GstAnalyzer * analyzer, char *uri) g_signal_connect (analyzer->sink, "new-frame", (GCallback) new_frame_callback, analyzer); - if (!strcmp (analyzer->codec_name, "mpeg2")) + if (!g_strcmp0 (analyzer->codec_name, "mpeg2")) g_object_set (G_OBJECT (analyzer->parser), "drop", FALSE, NULL); gst_bin_add_many (GST_BIN (analyzer->pipeline), analyzer->src, diff --git a/codecanalyzer/src/plugins/gst/analyzersink/gstanalyzersink.c b/codecanalyzer/src/plugins/gst/analyzersink/gstanalyzersink.c index 658822e79c..eb93dfad1d 100644 --- a/codecanalyzer/src/plugins/gst/analyzersink/gstanalyzersink.c +++ b/codecanalyzer/src/plugins/gst/analyzersink/gstanalyzersink.c @@ -182,7 +182,7 @@ gst_analyzer_sink_set_caps (GstBaseSink * bsink, GstCaps * caps) structure = gst_caps_get_structure (caps, 0); const gchar *name = gst_structure_get_name (structure); - if (!strcmp (name, "video/mpeg")) + if (!g_strcmp0 (name, "video/mpeg")) sink->codec_type = GST_ANALYZER_CODEC_MPEG2_VIDEO; else return FALSE;