From 17e5491b6091ab2443567f0fb454f191a1321e85 Mon Sep 17 00:00:00 2001 From: Philippe Normand Date: Mon, 23 Dec 2024 09:49:51 +0100 Subject: [PATCH] videodecoder: Gracefully handle missing data without prior input segment Exit early in case the decoder has been resetted and hasn't received a new segment event yet. This was detected with netsim dropping buffers in a WebRTC pipeline. Part-of: --- .../gst-libs/gst/video/gstvideodecoder.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/subprojects/gst-plugins-base/gst-libs/gst/video/gstvideodecoder.c b/subprojects/gst-plugins-base/gst-libs/gst/video/gstvideodecoder.c index 59672469c9..ccec1b823d 100644 --- a/subprojects/gst-plugins-base/gst-libs/gst/video/gstvideodecoder.c +++ b/subprojects/gst-plugins-base/gst-libs/gst/video/gstvideodecoder.c @@ -1307,14 +1307,19 @@ caps_error: } } +/* Must be called holding the GST_VIDEO_DECODER_STREAM_LOCK */ static gboolean -gst_video_decoder_handle_missing_data_default (GstVideoDecoder * - decoder, GstClockTime timestamp, GstClockTime duration) +gst_video_decoder_handle_missing_data_default (GstVideoDecoder * decoder, + GstClockTime timestamp, GstClockTime duration) { GstVideoDecoderPrivate *priv; priv = decoder->priv; + /* Exit early in case the decoder has been resetted and hasn't received a new segment event yet. */ + if (decoder->input_segment.format != GST_FORMAT_TIME) + return FALSE; + if (priv->automatic_request_sync_points) { GstClockTime deadline = gst_segment_to_running_time (&decoder->input_segment, GST_FORMAT_TIME,