From 16de48ae03651cd614c065175354e4f48f2947b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 4 Dec 2017 18:08:39 +0200 Subject: [PATCH] gst: gst_element_remove_pad() is transfer none for the pad While the refcount of the pad is decreased, it's the refcount that is owned by the parent (i.e. the element) and not the one passed in by the caller. Fixes a memory leak in bindings. --- gst/gstelement.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst/gstelement.c b/gst/gstelement.c index 97f327dc68..132dab1cef 100644 --- a/gst/gstelement.c +++ b/gst/gstelement.c @@ -751,7 +751,7 @@ no_direction: /** * gst_element_remove_pad: * @element: a #GstElement to remove pad from. - * @pad: (transfer full): the #GstPad to remove from the element. + * @pad: (transfer none): the #GstPad to remove from the element. * * Removes @pad from @element. @pad will be destroyed if it has not been * referenced elsewhere using gst_object_unparent().