From 158b4d8649bd73d2f3a72753bacc7dbdc3694688 Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Tue, 30 Jul 2019 23:54:48 +0900 Subject: [PATCH] nvenc: Fix crash with unspecified framerate Nvidia driver seems to calculating floating point framerate without validation. This causes crash both on linux and Windows. Fixes: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/1012 --- sys/nvcodec/gstnvbaseenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/nvcodec/gstnvbaseenc.c b/sys/nvcodec/gstnvbaseenc.c index 1cf3295324..e99f922908 100644 --- a/sys/nvcodec/gstnvbaseenc.c +++ b/sys/nvcodec/gstnvbaseenc.c @@ -1069,7 +1069,8 @@ gst_nv_base_enc_set_format (GstVideoEncoder * enc, GstVideoCodecState * state) params->frameRateNum = info->fps_n; params->frameRateDen = info->fps_d; } else { - GST_FIXME_OBJECT (nvenc, "variable framerate"); + params->frameRateNum = 0; + params->frameRateDen = 1; } if (gst_util_fraction_multiply (GST_VIDEO_INFO_WIDTH (info),