From 14c1bedb45600046298f6f90aea89b8b2298bdef Mon Sep 17 00:00:00 2001 From: Jordan Petridis Date: Sat, 21 Sep 2024 18:11:20 +0300 Subject: [PATCH] gstvafilter: Add back missing property comments In b1cda4439bc9170b4af60ab464471f58ea770f58 the property comments were removed, even though these are marked as public api. Add back the comments, and a Since version for interpolation-method. Part-of: --- .../docs/plugins/gst_plugins_cache.json | 20 +++++++++++++++---- .../gst-plugins-bad/sys/va/gstvafilter.c | 14 +++++++++++++ 2 files changed, 30 insertions(+), 4 deletions(-) diff --git a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json index a254a4f3b2..a994c19454 100644 --- a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json +++ b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json @@ -243301,12 +243301,24 @@ "type": "gboolean", "writable": true }, - "scale-method": { - "blurb": "Scale method to use", - "conditionally-available": false, + "interpolation-method": { + "blurb": "Interpolation method to use for scaling", + "conditionally-available": true, "construct": false, "construct-only": false, - "controllable": false, + "controllable": true, + "default": "default (0)", + "mutable": "playing", + "readable": true, + "type": "GstVaInterpolationMethod", + "writable": true + }, + "scale-method": { + "blurb": "Scale method to use", + "conditionally-available": true, + "construct": false, + "construct-only": false, + "controllable": true, "default": "default (0)", "mutable": "playing", "readable": true, diff --git a/subprojects/gst-plugins-bad/sys/va/gstvafilter.c b/subprojects/gst-plugins-bad/sys/va/gstvafilter.c index efe721784f..8a87d59b89 100644 --- a/subprojects/gst-plugins-bad/sys/va/gstvafilter.c +++ b/subprojects/gst-plugins-bad/sys/va/gstvafilter.c @@ -699,6 +699,13 @@ gst_va_filter_install_properties (GstVaFilter * self, GObjectClass * klass) common_flags)); } + /** + * GstVaPostProc:scale-method + * + * Sets the scale method algorithm to use when resizing. + * + * Since: 1.22 + */ if (GST_VA_DISPLAY_IS_IMPLEMENTATION (self->display, INTEL_IHD)) { g_object_class_install_property (klass, GST_VA_FILTER_PROP_SCALE_METHOD, @@ -707,6 +714,13 @@ gst_va_filter_install_properties (GstVaFilter * self, GObjectClass * klass) GST_TYPE_VA_SCALE_METHOD, VA_FILTER_SCALING_DEFAULT, common_flags)); } + /** + * GstVaPostProc:interpolation-method + * + * Sets the interpolation method algorithm to use when resizing. + * + * Since: 1.26 + */ if (GST_VA_DISPLAY_IS_IMPLEMENTATION (self->display, INTEL_IHD)) { g_object_class_install_property (klass, GST_VA_FILTER_PROP_INTERPOLATION_METHOD,