From 145f8546c4d95812c19e8e2930305c96d1011071 Mon Sep 17 00:00:00 2001
From: Nirbheek Chauhan <nirbheek@centricular.com>
Date: Wed, 19 Jun 2019 03:19:16 +0530
Subject: [PATCH] gstinfo: Add an explicit enum for GST_STACK_TRACE_SHOW_NONE

The code implicitly uses this value when the stack trace is not FULL.
Mostly useful for documenting the behaviour when each flag is passed
and for translating to/from strings.
---
 gst/gstinfo.c              | 4 ++--
 gst/gstinfo.h              | 9 +++++++--
 plugins/tracers/gstleaks.c | 2 +-
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/gst/gstinfo.c b/gst/gstinfo.c
index 63f9fca35e..fffa83935c 100644
--- a/gst/gstinfo.c
+++ b/gst/gstinfo.c
@@ -2885,8 +2885,8 @@ done:
 
 /**
  * gst_debug_get_stack_trace:
- * @flags: A set of #GstStackTraceFlags to determine how the stack
- * trace should look like. Pass 0 to retrieve a minimal backtrace.
+ * @flags: A set of #GstStackTraceFlags to determine how the stack trace should
+ * look like. Pass #GST_STACK_TRACE_SHOW_NONE to retrieve a minimal backtrace.
  *
  * Returns: (nullable): a stack trace, if libunwind or glibc backtrace are
  * present, else %NULL.
diff --git a/gst/gstinfo.h b/gst/gstinfo.h
index ceaa70eb07..257564ab36 100644
--- a/gst/gstinfo.h
+++ b/gst/gstinfo.h
@@ -177,12 +177,17 @@ typedef enum { /*< flags >*/
 
 /**
  * GstStackTraceFlags:
- * @GST_STACK_TRACE_SHOW_FULL: Try to retrieve as much information as
- *                             possible when getting the stack trace
+ * @GST_STACK_TRACE_SHOW_NONE: Try to retrieve the minimum information
+ *                             available, which may be none on some platforms
+ *                             (Since: 1.18)
+ * @GST_STACK_TRACE_SHOW_FULL: Try to retrieve as much information as possible,
+ *                             including source information when getting the
+ *                             stack trace
  *
  * Since: 1.12
  */
 typedef enum {
+    GST_STACK_TRACE_SHOW_NONE = 0,
     GST_STACK_TRACE_SHOW_FULL = 1 << 0
 } GstStackTraceFlags;
 
diff --git a/plugins/tracers/gstleaks.c b/plugins/tracers/gstleaks.c
index 22a005a2f3..80e44aa614 100644
--- a/plugins/tracers/gstleaks.c
+++ b/plugins/tracers/gstleaks.c
@@ -106,7 +106,7 @@ set_print_stack_trace_from_string (GstLeaksTracer * self, const gchar * str)
   if (g_strcmp0 (str, "full") == 0)
     self->trace_flags = GST_STACK_TRACE_SHOW_FULL;
   else
-    self->trace_flags = 0;
+    self->trace_flags = GST_STACK_TRACE_SHOW_NONE;
 }
 
 static void