From 135707290eafd99b0e35eed7a9da179ace0dc438 Mon Sep 17 00:00:00 2001
From: Thibault Saunier <tsaunier@igalia.com>
Date: Wed, 24 Jun 2020 11:11:11 -0400
Subject: [PATCH] *uri-source: Call free from the object ->finalize not
 ->dispose

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-editing-services/-/merge_requests/198>
---
 ges/ges-audio-uri-source.c | 9 ++++-----
 ges/ges-video-uri-source.c | 6 +++---
 2 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/ges/ges-audio-uri-source.c b/ges/ges-audio-uri-source.c
index 7f0d0ced85..355d861346 100644
--- a/ges/ges-audio-uri-source.c
+++ b/ges/ges-audio-uri-source.c
@@ -159,14 +159,13 @@ ges_audio_uri_source_set_property (GObject * object, guint property_id,
 }
 
 static void
-ges_audio_uri_source_dispose (GObject * object)
+ges_audio_uri_source_finalize (GObject * object)
 {
   GESAudioUriSource *uriclip = GES_AUDIO_URI_SOURCE (object);
 
-  if (uriclip->uri)
-    g_free (uriclip->uri);
+  g_free (uriclip->uri);
 
-  G_OBJECT_CLASS (ges_audio_uri_source_parent_class)->dispose (object);
+  G_OBJECT_CLASS (ges_audio_uri_source_parent_class)->finalize (object);
 }
 
 static void
@@ -178,7 +177,7 @@ ges_audio_uri_source_class_init (GESAudioUriSourceClass * klass)
 
   object_class->get_property = ges_audio_uri_source_get_property;
   object_class->set_property = ges_audio_uri_source_set_property;
-  object_class->dispose = ges_audio_uri_source_dispose;
+  object_class->finalize = ges_audio_uri_source_finalize;
 
   /**
    * GESAudioUriSource:uri:
diff --git a/ges/ges-video-uri-source.c b/ges/ges-video-uri-source.c
index 0595ceacd4..819ab5a43e 100644
--- a/ges/ges-video-uri-source.c
+++ b/ges/ges-video-uri-source.c
@@ -320,13 +320,13 @@ ges_video_uri_source_set_property (GObject * object, guint property_id,
 }
 
 static void
-ges_video_uri_source_dispose (GObject * object)
+ges_video_uri_source_finalize (GObject * object)
 {
   GESVideoUriSource *urisource = GES_VIDEO_URI_SOURCE (object);
 
   g_free (urisource->uri);
 
-  G_OBJECT_CLASS (ges_video_uri_source_parent_class)->dispose (object);
+  G_OBJECT_CLASS (ges_video_uri_source_parent_class)->finalize (object);
 }
 
 static void
@@ -337,7 +337,7 @@ ges_video_uri_source_class_init (GESVideoUriSourceClass * klass)
 
   object_class->get_property = ges_video_uri_source_get_property;
   object_class->set_property = ges_video_uri_source_set_property;
-  object_class->dispose = ges_video_uri_source_dispose;
+  object_class->finalize = ges_video_uri_source_finalize;
 
   /**
    * GESVideoUriSource:uri: