From 11f298a33864d22d9c3168dcdb77111f5f7dea99 Mon Sep 17 00:00:00 2001 From: Jose Antonio Santos Cadenas Date: Mon, 22 Jun 2015 11:28:13 +0200 Subject: [PATCH] rtpsource: Do not try to push NULL buffers If update_receiver_stats() fails, we can't really do anything with this buffer anymore and have to drop it. This happens if there's a big seqnum discontinuity for example. https://bugzilla.gnome.org/show_bug.cgi?id=751311 --- gst/rtpmanager/rtpsource.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/gst/rtpmanager/rtpsource.c b/gst/rtpmanager/rtpsource.c index 18db75158a..e26817b55d 100644 --- a/gst/rtpmanager/rtpsource.c +++ b/gst/rtpmanager/rtpsource.c @@ -1216,12 +1216,14 @@ rtp_source_send_rtp (RTPSource * src, RTPPacketInfo * pinfo) /* we are a sender now */ src->is_sender = TRUE; + /* we are also a receiver of our packets */ + if (!update_receiver_stats (src, pinfo)) + return GST_FLOW_OK; + /* update stats for the SR */ src->stats.packets_sent += pinfo->packets; src->stats.octets_sent += pinfo->payload_len; src->bytes_sent += pinfo->payload_len; - /* we are also a receiver of our packets */ - update_receiver_stats (src, pinfo); running_time = pinfo->running_time;