From 10271809605a084c5aee56c7ef9d7c5a1e1a2789 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Tue, 4 Jul 2023 15:37:16 +0200 Subject: [PATCH] subtitleoverlay: fix mutex error if sink caps is not video We were trying to unlock a mutex that was not locked. Part-of: --- subprojects/gst-plugins-base/gst/playback/gstsubtitleoverlay.c | 1 - 1 file changed, 1 deletion(-) diff --git a/subprojects/gst-plugins-base/gst/playback/gstsubtitleoverlay.c b/subprojects/gst-plugins-base/gst/playback/gstsubtitleoverlay.c index 9a0c5741a1..cc2ee06cd9 100644 --- a/subprojects/gst-plugins-base/gst/playback/gstsubtitleoverlay.c +++ b/subprojects/gst-plugins-base/gst/playback/gstsubtitleoverlay.c @@ -1736,7 +1736,6 @@ gst_subtitle_overlay_video_sink_setcaps (GstSubtitleOverlay * self, if (!gst_video_info_from_caps (&info, caps)) { GST_ERROR_OBJECT (self, "Failed to parse caps"); ret = FALSE; - GST_SUBTITLE_OVERLAY_UNLOCK (self); goto out; }