From 0f7bb97e81067fe8ae35f2451ee667ea48afc1dc Mon Sep 17 00:00:00 2001
From: Chris Spoelstra <cs.spoelstra@gmail.com>
Date: Fri, 7 Apr 2023 14:40:58 -0400
Subject: [PATCH] srtsrc: fix case fallthrough of authentication param

Add missing breaks to two case statements.
Also adds a missing lock of srtobject->element when getting the value
of PROP_AUTHENTICATION.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/4367>
---
 .../gst-plugins-bad/docs/plugins/gst_plugins_cache.json   | 8 ++++----
 subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c        | 4 ++++
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
index 1893699325..611d97fae0 100644
--- a/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
+++ b/subprojects/gst-plugins-bad/docs/plugins/gst_plugins_cache.json
@@ -238774,7 +238774,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "true",
+                        "default": "false",
                         "mutable": "null",
                         "readable": true,
                         "type": "gboolean",
@@ -239022,7 +239022,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "true",
+                        "default": "false",
                         "mutable": "null",
                         "readable": true,
                         "type": "gboolean",
@@ -239330,7 +239330,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "true",
+                        "default": "false",
                         "mutable": "null",
                         "readable": true,
                         "type": "gboolean",
@@ -239567,7 +239567,7 @@
                         "construct": false,
                         "construct-only": false,
                         "controllable": false,
-                        "default": "true",
+                        "default": "false",
                         "mutable": "null",
                         "readable": true,
                         "type": "gboolean",
diff --git a/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c b/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c
index 1b003e4c43..ce15c0b022 100644
--- a/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c
+++ b/subprojects/gst-plugins-bad/ext/srt/gstsrtobject.c
@@ -447,6 +447,7 @@ gst_srt_object_set_property_helper (GstSRTObject * srtobject,
       break;
     case PROP_AUTHENTICATION:
       srtobject->authentication = g_value_get_boolean (value);
+      break;
     case PROP_AUTO_RECONNECT:
       srtobject->auto_reconnect = g_value_get_boolean (value);
       break;
@@ -555,7 +556,10 @@ gst_srt_object_get_property_helper (GstSRTObject * srtobject,
       GST_OBJECT_UNLOCK (srtobject->element);
       break;
     case PROP_AUTHENTICATION:
+      GST_OBJECT_LOCK (srtobject->element);
       g_value_set_boolean (value, srtobject->authentication);
+      GST_OBJECT_UNLOCK (srtobject->element);
+      break;
     case PROP_AUTO_RECONNECT:
       GST_OBJECT_LOCK (srtobject->element);
       g_value_set_boolean (value, srtobject->auto_reconnect);