From 0e9314ac7c77b763814ea7af89f2ab593198f33b Mon Sep 17 00:00:00 2001 From: "Joshua N. Pritikin" Date: Mon, 17 Sep 2001 23:56:30 +0000 Subject: [PATCH] revert detailed multi-line error report Original commit message from CVS: revert detailed multi-line error report --- gst/gstpad.c | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/gst/gstpad.c b/gst/gstpad.c index b099ca196e..83f012eeb0 100644 --- a/gst/gstpad.c +++ b/gst/gstpad.c @@ -557,33 +557,18 @@ gst_pad_disconnect (GstPad *srcpad, * Connects the source pad to the sink pad. * * You shouldn't use this API in a real application because the - * failure mode dumps detailed diagnostics to stderr. A professional - * application should always use gst_pad_try_connect and check - * the return code. - * - * This API will probably be moved out of the main gstreamer library. + * failure mode dumps diagnostics to stderr. A professional + * application should never fail, or use gst_pad_try_connect and + * check the return code. */ void gst_pad_connect (GstPad *srcpad, GstPad *sinkpad) { if (!gst_pad_try_connect (srcpad, sinkpad)) - { - GString *buf; - - buf = g_string_new (NULL); - g_string_printf (buf, "\nCouldn't connect %s:%s and %s:%s -- details:\n", - GST_DEBUG_PAD_NAME (srcpad), - GST_DEBUG_PAD_NAME (sinkpad)); - gst_print_pad_caps (buf, 2, srcpad); - gst_print_pad_caps (buf, 2, sinkpad); - - g_critical (buf->str, - GST_DEBUG_PAD_NAME (srcpad), - GST_DEBUG_PAD_NAME (sinkpad)); - - g_string_free (buf, TRUE); - } + g_critical ("couldn't connect %s:%s and %s:%s", + GST_DEBUG_PAD_NAME (srcpad), + GST_DEBUG_PAD_NAME (sinkpad)); } /**