From 0e3d6f0606c62af4233838daca56646095facc50 Mon Sep 17 00:00:00 2001 From: Guillaume Desmottes Date: Thu, 23 Jan 2025 13:20:50 +0100 Subject: [PATCH] wpe: remove glFlush() when filling buffer According to https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4162#note_2739338 it was introduced as workaround for tearing issues. I do not experience any tearing without flushing on both nvidia and AMD GPU, so I suppose it's no longer needed. Slightly improve CPU usage according to my tests. Part-of: --- subprojects/gst-plugins-bad/ext/wpe/gstwpevideosrc.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/subprojects/gst-plugins-bad/ext/wpe/gstwpevideosrc.cpp b/subprojects/gst-plugins-bad/ext/wpe/gstwpevideosrc.cpp index ceb28ca6d3..63a20c5386 100644 --- a/subprojects/gst-plugins-bad/ext/wpe/gstwpevideosrc.cpp +++ b/subprojects/gst-plugins-bad/ext/wpe/gstwpevideosrc.cpp @@ -281,7 +281,6 @@ gst_wpe_video_src_fill_memory (GstGLBaseSrc * bsrc, GstGLMemory * memory) gl->BindTexture (GL_TEXTURE_2D, tex_id); gl->EGLImageTargetTexture2D (GL_TEXTURE_2D, gst_egl_image_get_image (locked_image)); - gl->Flush (); WPE_UNLOCK (src); return TRUE; }