From 0bfc9fb21202441a0ca848cd3d8eeef696f882e6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Wed, 29 Jun 2016 13:11:01 +0200 Subject: [PATCH] poll: Warn if the return value of gst_poll_read_control() is unused This might fail even under correct usage, e.g. if read_control() is called from another thread before write_control() finished in another. It has to be retried then, or other measures have to be taken, depending on how it is used by the surrounding code. https://bugzilla.gnome.org/show_bug.cgi?id=750397 --- gst/gstpoll.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gst/gstpoll.h b/gst/gstpoll.h index 8bf64fd584..ef6dceaf2c 100644 --- a/gst/gstpoll.h +++ b/gst/gstpoll.h @@ -88,7 +88,7 @@ void gst_poll_restart (GstPoll *set); void gst_poll_set_flushing (GstPoll *set, gboolean flushing); gboolean gst_poll_write_control (GstPoll *set); -gboolean gst_poll_read_control (GstPoll *set); +gboolean gst_poll_read_control (GstPoll *set) G_GNUC_WARN_UNUSED_RESULT; G_END_DECLS