From 0bd6f374c8b527fb0efa25c583af3714cf08cc5b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tim-Philipp=20M=C3=BCller?= Date: Tue, 13 Aug 2013 17:47:14 +0100 Subject: [PATCH] codecparsers: mpegvideoparse: turn internal consistency check into a g_assert() We only check input from the API user with g_return_*_if_fail(). Internal sanity checks should use g_assert() instead, which is disabled by default for releases. --- gst-libs/gst/codecparsers/gstmpegvideoparser.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gst-libs/gst/codecparsers/gstmpegvideoparser.c b/gst-libs/gst/codecparsers/gstmpegvideoparser.c index 42654eed46..2fd992f24d 100644 --- a/gst-libs/gst/codecparsers/gstmpegvideoparser.c +++ b/gst-libs/gst/codecparsers/gstmpegvideoparser.c @@ -200,14 +200,13 @@ set_fps_from_code (GstMpegVideoSequenceHdr * seqhdr, guint8 fps_code) } /* @size and @offset are wrt current reader position */ -static inline guint +static inline gint scan_for_start_codes (const GstByteReader * reader, guint offset, guint size) { const guint8 *data; guint i = 0; - g_return_val_if_fail ((guint64) offset + size <= reader->size - reader->byte, - -1); + g_assert ((guint64) offset + size <= reader->size - reader->byte); /* we can't find the pattern with less than 4 bytes */ if (G_UNLIKELY (size < 4))