mirrors/gstreamer
mirrors/gstreamer
1
1
Fork 0
mirror of https://gitlab.freedesktop.org/gstreamer/gstreamer.git synced 2024-11-30 13:41:48 +00:00
Code Issues 1 Projects Releases Wiki Activity

buffer: Don't copy "memory" metas unconditionally

Browse source 
Don't copy memory metas if we only copied part of the buffer, didn't
copy memories or merged memories. In all these cases the memory
structure has changed and the memory meta becomes meaningless.

https://bugzilla.gnome.org/show_bug.cgi?id=751712
This commit is contained in:
Sebastian Dröge 2015-07-01 10:36:36 +02:00
parent d43f256a9e
commit 0aae36567d
1 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
gst/gstbuffer.c
View file

@ -534,7 +534,17 @@ gst_buffer_copy_into (GstBuffer * dest, GstBuffer * src,
GstMeta *meta = &walk->meta; GstMeta *meta = &walk->meta;
const GstMetaInfo *info = meta->info; const GstMetaInfo *info = meta->info;
if (info->transform_func) { /* Don't copy memory metas if we only copied part of the buffer, didn't
* copy memories or merged memories. In all these cases the memory
* structure has changed and the memory meta becomes meaningless.
*/
if ((region || !(flags & GST_BUFFER_COPY_MEMORY)
|| (flags & GST_BUFFER_COPY_MERGE))
&& gst_meta_api_type_has_tag (info->api, _gst_meta_tag_memory)) {
GST_CAT_DEBUG (GST_CAT_BUFFER,
"don't copy memory meta %p of API type %s", meta,
g_type_name (info->api));
} else if (info->transform_func) {
GstMetaTransformCopy copy_data; GstMetaTransformCopy copy_data;
copy_data.region = region; copy_data.region = region;