From 0a41beaa5662fca64418ad1090bcd3439722b65d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Tue, 23 Jul 2013 18:53:44 +0200 Subject: [PATCH] basesink: Print some debug output if a stream-start event without group-id arrives Ideally all elements would implement handling of that to get proper stream-start message handling and other things. --- libs/gst/base/gstbasesink.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libs/gst/base/gstbasesink.c b/libs/gst/base/gstbasesink.c index 9bbff1efff..cd9380b9ac 100644 --- a/libs/gst/base/gstbasesink.c +++ b/libs/gst/base/gstbasesink.c @@ -3014,8 +3014,13 @@ gst_base_sink_default_event (GstBaseSink * basesink, GstEvent * event) GST_DEBUG_OBJECT (basesink, "Now posting STREAM_START (seqnum:%d)", seqnum); message = gst_message_new_stream_start (GST_OBJECT_CAST (basesink)); - if (gst_event_parse_group_id (event, &group_id)) + if (gst_event_parse_group_id (event, &group_id)) { gst_message_set_group_id (message, group_id); + } else { + GST_FIXME_OBJECT (basesink, "stream-start event without group-id. " + "Consider implementing group-id handling in the upstream " + "elements"); + } gst_message_set_seqnum (message, seqnum); gst_element_post_message (GST_ELEMENT_CAST (basesink), message); break;