From 07901d8eede0500472210f21eb3bea5460d131f4 Mon Sep 17 00:00:00 2001 From: Vineeth TM Date: Thu, 12 Nov 2015 16:18:35 +0900 Subject: [PATCH] glcolorconvert: Fix string leak String got using gst_glsl_version_profile_to_string, is allocated memory and should be freed https://bugzilla.gnome.org/show_bug.cgi?id=757974 --- gst-libs/gst/gl/gstglcolorconvert.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gst-libs/gst/gl/gstglcolorconvert.c b/gst-libs/gst/gl/gstglcolorconvert.c index ef44827497..4eb3ac5bde 100644 --- a/gst-libs/gst/gl/gstglcolorconvert.c +++ b/gst-libs/gst/gl/gstglcolorconvert.c @@ -1582,7 +1582,7 @@ _create_shader (GstGLColorConvert * convert) GstGLSLStage *stage; GstGLSLVersion version; GstGLSLProfile profile; - gchar *version_str, *tmp; + gchar *version_str, *tmp, *tmp1; const gchar *strings[2]; GError *error = NULL; GstGLAPI gl_api; @@ -1596,8 +1596,9 @@ _create_shader (GstGLColorConvert * convert) _mangle_shader (text_vertex_shader, GL_VERTEX_SHADER, info->templ->target, convert->priv->from_texture_target, gl_api, &version, &profile); - version_str = g_strdup_printf ("#version %s\n", - gst_glsl_version_profile_to_string (version, profile)); + tmp1 = gst_glsl_version_profile_to_string (version, profile); + version_str = g_strdup_printf ("#version %s\n", tmp1); + g_free (tmp1); strings[0] = version_str; strings[1] = tmp;