From 075a5df24f149ce08e7550b389baa829d6d5d64c Mon Sep 17 00:00:00 2001 From: Seungha Yang Date: Mon, 14 Jan 2019 23:38:19 +0900 Subject: [PATCH] transition-clip: Don't leak GESAsset Returned GESAsset from ges_asset_request should be freed since ges_extractable_set_asset doesn't take ownership --- ges/ges-transition-clip.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ges/ges-transition-clip.c b/ges/ges-transition-clip.c index 8a64291ea0..dda64cf6ae 100644 --- a/ges/ges-transition-clip.c +++ b/ges/ges-transition-clip.c @@ -98,9 +98,12 @@ ges_transition_clip_update_vtype_internal (GESClip * trself->priv->vtype_name = asset_id; if (set_asset) { + GESAsset *asset = + ges_asset_request (GES_TYPE_TRANSITION_CLIP, asset_id, NULL); + /* We already checked the value, so we can be sure no error will accured */ - ges_extractable_set_asset (GES_EXTRACTABLE (self), - ges_asset_request (GES_TYPE_TRANSITION_CLIP, asset_id, NULL)); + ges_extractable_set_asset (GES_EXTRACTABLE (self), asset); + gst_object_unref (asset); } }