From 05cc418ca23a7a3c3603b30db8599d989fac0b77 Mon Sep 17 00:00:00 2001 From: Ilya Konstantinov Date: Tue, 12 May 2015 00:18:02 +0200 Subject: [PATCH] avfassetsrc: fix huge memory leak CMSampleBuffers were retained -> huge memory leak. https://bugzilla.gnome.org/show_bug.cgi?id=750638 --- sys/applemedia/avfassetsrc.m | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/applemedia/avfassetsrc.m b/sys/applemedia/avfassetsrc.m index 0a40c0dbcc..0aaf3adcfe 100644 --- a/sys/applemedia/avfassetsrc.m +++ b/sys/applemedia/avfassetsrc.m @@ -1084,6 +1084,10 @@ gst_avf_asset_src_uri_handler_init (gpointer g_iface, gpointer iface_data) } buf = gst_core_media_buffer_new (cmbuf, FALSE, TRUE); + CFRelease (cmbuf); + if (buf == NULL) + return NULL; + /* cmbuf is now retained by buf (in meta) */ dur = CMSampleBufferGetDuration (cmbuf); ts = CMSampleBufferGetPresentationTimeStamp (cmbuf); if (dur.value != 0) {