From 03b299ecdbc7081c6dd2f8ae0334b8ca28064de3 Mon Sep 17 00:00:00 2001
From: Brandon Lewis <brandon@collabora.co.uk>
Date: Thu, 10 Jun 2010 16:19:11 +0200
Subject: [PATCH] release the request pads in dispose

---
 ges/ges-track-transition.c | 19 +++++++++++++++++--
 ges/ges-track-transition.h |  3 +++
 2 files changed, 20 insertions(+), 2 deletions(-)

diff --git a/ges/ges-track-transition.c b/ges/ges-track-transition.c
index 3d45f26dbd..3e87b820fa 100644
--- a/ges/ges-track-transition.c
+++ b/ges/ges-track-transition.c
@@ -157,6 +157,8 @@ ges_track_transition_dispose (GObject * object)
   GESTrackTransition *self = GES_TRACK_TRANSITION (object);
 
   GST_DEBUG ("disposing");
+  GST_LOG ("mixer: %p smpte: %p sinka: %p sinkb: %p",
+      self->vmixer, self->vsmpte, self->sinka, self->sinkb);
 
   if (self->vcontroller) {
     g_object_unref (self->vcontroller);
@@ -182,6 +184,14 @@ ges_track_transition_dispose (GObject * object)
     self->a_bcontrol_source = NULL;
   }
 
+  if (self->sinka) {
+    GST_DEBUG ("releasing request pads for vmixer");
+    gst_element_release_request_pad (self->vmixer, self->sinka);
+    gst_element_release_request_pad (self->vmixer, self->sinkb);
+    self->vmixer = NULL;
+    self->sinka = NULL;
+    self->sinkb = NULL;
+  }
 
   G_OBJECT_CLASS (ges_track_transition_parent_class)->dispose (object);
 }
@@ -269,8 +279,10 @@ create_video_bin (GESTrackTransition * self)
     self->vstart_value = 1.0;
     self->vend_value = 0.0;
   } else {
-    link_element_to_mixer (iconva, mixer);
-    target = link_element_to_mixer (iconvb, mixer);
+    self->sinka = (GstPad *) link_element_to_mixer (iconva, mixer);
+    self->sinkb = (GstPad *) link_element_to_mixer (iconvb, mixer);
+    target = (GObject *) self->sinkb;
+    self->vmixer = mixer;
     propname = "alpha";
     self->vstart_value = 0.0;
     self->vend_value = 1.0;
@@ -439,6 +451,9 @@ ges_track_transition_init (GESTrackTransition * self)
   self->vcontroller = NULL;
   self->vcontrol_source = NULL;
   self->vsmpte = NULL;
+  self->vmixer = NULL;
+  self->sinka = NULL;
+  self->sinkb = NULL;
   self->vtype = 0;
   self->vstart_value = 0.0;
   self->vend_value = 0.0;
diff --git a/ges/ges-track-transition.h b/ges/ges-track-transition.h
index cae7bf42b0..b22c9fe460 100644
--- a/ges/ges-track-transition.h
+++ b/ges/ges-track-transition.h
@@ -75,6 +75,9 @@ struct _GESTrackTransition
 
   /* so we can support changing between wipes */
   GstElement                    *vsmpte;
+  GstElement                    *vmixer;
+  GstPad                        *sinka;
+  GstPad                        *sinkb;
   
   /* these will be different depending on whether smptealpha or alpha element
    * is used */