From 031bcfd561d054970e251ee152d5615b19174493 Mon Sep 17 00:00:00 2001 From: Thomas Vander Stichele Date: Mon, 2 Feb 2004 17:29:30 +0000 Subject: [PATCH] suffix error with period Original commit message from CVS: suffix error with period --- ChangeLog | 5 +++++ docs/random/error | 4 ++-- gst/gstelement.c | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 861bd4e601..af2cae7af2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2004-02-02 Thomas Vander Stichele + + * gst/gstelement.c: (gst_element_default_error): + suffix error messages with period + 2004-01-31 Thomas Vander Stichele * gst/elements/gstfilesrc.c: (gst_filesrc_open_file): diff --git a/docs/random/error b/docs/random/error index faf2a46d44..7dba910d86 100644 --- a/docs/random/error +++ b/docs/random/error @@ -24,8 +24,8 @@ Some notes on the error handling introduced after 0.7.3 - message is either NULL (to signal the standard error message for the given domain and code), or a printf-like set with the format being marked for translation. - The string should start with a capital and not end in a period - (FIXME: this is something we may want to change). + The string should start with a capital and end in a period so it forms + a complete sentence. The string can/should be shown to the user of an application. - debug is either NULL or a non-translated debug string, which can be used to diagnose errors after they've happened. diff --git a/gst/gstelement.c b/gst/gstelement.c index 454cc1ade9..df23ec36de 100644 --- a/gst/gstelement.c +++ b/gst/gstelement.c @@ -236,7 +236,7 @@ gst_element_default_error (GObject *object, GstObject *source, GError *error, gc { gchar *name = gst_object_get_path_string (source); - g_print (_("ERROR: from element %s: %s.\n"), name, error->message); + g_print (_("ERROR: from element %s: %s\n"), name, error->message); if (debug) g_print (_("Additional debug info:\n%s\n"), debug);