From 02fc41fde55ea777bed6018aa8bef6dbe164405f Mon Sep 17 00:00:00 2001
From: Martin Storsjo <martin@martin.st>
Date: Tue, 3 May 2011 14:14:20 +0300
Subject: [PATCH] qtwrapper: Replace the hackish 42 magic number with a define

---
 sys/qtwrapper/audiodecoders.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/sys/qtwrapper/audiodecoders.c b/sys/qtwrapper/audiodecoders.c
index 718d30cb27..d7791d04fd 100644
--- a/sys/qtwrapper/audiodecoders.c
+++ b/sys/qtwrapper/audiodecoders.c
@@ -62,6 +62,8 @@
 
 #define QTWRAPPER_ADEC_PARAMS_QDATA g_quark_from_static_string("qtwrapper-adec-params")
 
+#define NO_MORE_INPUT_DATA 42
+
 static GstStaticPadTemplate src_templ = GST_STATIC_PAD_TEMPLATE ("src",
     GST_PAD_SRC,
     GST_PAD_ALWAYS,
@@ -745,9 +747,9 @@ process_buffer_cb (ComponentInstance inAudioConverter,
     return noErr;
   }
 
-  GST_LOG_OBJECT (qtwrapper, "No remaining input data, returning 42 for hack");
+  GST_LOG_OBJECT (qtwrapper, "No remaining input data, returning NO_MORE_INPUT_DATA");
 
-  return 42;
+  return NO_MORE_INPUT_DATA;
 }
 
 static GstFlowReturn
@@ -805,8 +807,7 @@ qtwrapper_audio_decoder_chain (GstPad * pad, GstBuffer * buf)
         (SCAudioInputDataProc) process_buffer_cb,
         qtwrapper, (UInt32 *) & outsamples, qtwrapper->bufferlist, NULL);
 
-    /* TODO: What's this '42' crap?? It does seem to be needed, though. */
-    if ((status != noErr) && (status != 42)) {
+    if ((status != noErr) && (status != NO_MORE_INPUT_DATA)) {
       if (status < 0)
         GST_WARNING_OBJECT (qtwrapper,
             "Error in SCAudioFillBuffer() : %d", (gint32) status);