From 027f4a56c0080e07f3396d403ccb05af97573932 Mon Sep 17 00:00:00 2001 From: Philippe Normand Date: Mon, 7 Mar 2022 10:14:43 +0000 Subject: [PATCH] gstplay: Fix warning parsing API The GError is an out parameter, so should be a ** parameter, like the details parameter. See also #1063 Part-of: --- subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c | 4 ++-- subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c index e03ff3fde3..ba1322e7fb 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c +++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.c @@ -4676,14 +4676,14 @@ gst_play_message_parse_error (GstMessage * msg, GError ** error, * gst_play_message_parse_warning: * @msg: A #GstMessage * @error: (out) (optional) (transfer full): the resulting warning - * @details: (out) (optional) (nullable) (transfer full): A GstStructure containing extra details about the error + * @details: (out) (optional) (nullable) (transfer full): A #GstStructure containing additional details about the warning * * Parse the given error @msg and extract the corresponding #GError warning * * Since: 1.20 */ void -gst_play_message_parse_warning (GstMessage * msg, GError * error, +gst_play_message_parse_warning (GstMessage * msg, GError ** error, GstStructure ** details) { PARSE_MESSAGE_FIELD (msg, GST_PLAY_MESSAGE_DATA_WARNING, G_TYPE_ERROR, error); diff --git a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.h b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.h index 0b703e77b3..9ffc1e1dff 100644 --- a/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.h +++ b/subprojects/gst-plugins-bad/gst-libs/gst/play/gstplay.h @@ -423,7 +423,7 @@ GST_PLAY_API void gst_play_message_parse_error (GstMessage *msg, GError **error, GstStructure **details); GST_PLAY_API -void gst_play_message_parse_warning (GstMessage *msg, GError *error, GstStructure **details); +void gst_play_message_parse_warning (GstMessage *msg, GError **error, GstStructure **details); GST_PLAY_API void gst_play_message_parse_video_dimensions_changed (GstMessage *msg, guint *width, guint *height);