diff --git a/gstreamer-base/src/adapter.rs b/gstreamer-base/src/adapter.rs index 6a4bcfb50..8a3298cd8 100644 --- a/gstreamer-base/src/adapter.rs +++ b/gstreamer-base/src/adapter.rs @@ -258,8 +258,7 @@ impl io::Read for Adapter { len = buf.len(); } - self.copy(0, &mut buf[0..len]) - .map_err(|err| io::Error::new(io::ErrorKind::Other, err))?; + self.copy(0, &mut buf[0..len]).map_err(io::Error::other)?; self.flush(len); diff --git a/gstreamer-base/src/subclass/base_transform.rs b/gstreamer-base/src/subclass/base_transform.rs index dfcf9610e..a34b7db8a 100644 --- a/gstreamer-base/src/subclass/base_transform.rs +++ b/gstreamer-base/src/subclass/base_transform.rs @@ -454,14 +454,14 @@ pub trait BaseTransformImplExt: BaseTransformImpl { (&mut outbuf) as *mut *mut gst::ffi::GstBuffer as *mut gst::ffi::GstBuffer, )) .map(|_| { - if outbuf == buf as *mut _ { + if ptr::eq(outbuf, buf as *mut _) { PrepareOutputBufferSuccess::InputBuffer } else { PrepareOutputBufferSuccess::Buffer(from_glib_full(outbuf)) } }) .inspect_err(|_err| { - if outbuf != buf as *mut _ { + if !ptr::eq(outbuf, buf as *mut _) { drop(Option::::from_glib_full(outbuf)); } })