From bc3e1404d6890fe281f2e1da1b0230c9b77acee7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Mon, 13 Feb 2023 14:28:47 +0200 Subject: [PATCH] video: Don't forget to unmap the `VideoFrame` when converting into a `gst::Buffer` Part-of: --- gstreamer-video/src/video_frame.rs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gstreamer-video/src/video_frame.rs b/gstreamer-video/src/video_frame.rs index e92e89777..a65ee9a2b 100644 --- a/gstreamer-video/src/video_frame.rs +++ b/gstreamer-video/src/video_frame.rs @@ -46,8 +46,12 @@ impl VideoFrame { #[inline] pub fn into_buffer(self) -> gst::Buffer { - let s = mem::ManuallyDrop::new(self); - unsafe { ptr::read(&s.buffer) } + unsafe { + let mut s = mem::ManuallyDrop::new(self); + let buffer = ptr::read(&s.buffer); + ffi::gst_video_frame_unmap(&mut s.frame); + buffer + } } #[doc(alias = "gst_video_frame_copy")]