From 92064a0c4108f3fb3f3015f551fff97cc4d17d28 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Fri, 5 Jan 2024 22:27:07 +0200 Subject: [PATCH] Remove `&mut BufferRef` getter from write-mapped `AudioBuffer` / `VideoFrame` This allows invalidating the buffer map. Part-of: --- gstreamer-audio/src/audio_buffer.rs | 10 ---------- gstreamer-video/src/video_frame.rs | 10 ---------- 2 files changed, 20 deletions(-) diff --git a/gstreamer-audio/src/audio_buffer.rs b/gstreamer-audio/src/audio_buffer.rs index bc5b66cc3..663246af8 100644 --- a/gstreamer-audio/src/audio_buffer.rs +++ b/gstreamer-audio/src/audio_buffer.rs @@ -233,11 +233,6 @@ impl AudioBuffer { } } - #[inline] - pub fn buffer_mut(&mut self) -> &mut gst::BufferRef { - unsafe { gst::BufferRef::from_mut_ptr(self.audio_buffer.buffer) } - } - pub fn plane_data_mut(&mut self, plane: u32) -> Result<&mut [u8], glib::BoolError> { if plane >= self.n_planes() { return Err(glib::bool_error!( @@ -530,11 +525,6 @@ impl<'a> AudioBufferRef<&'a mut gst::BufferRef> { } } - #[inline] - pub fn buffer_mut(&mut self) -> &mut gst::BufferRef { - unsafe { gst::BufferRef::from_mut_ptr(self.audio_buffer.buffer) } - } - #[inline] pub fn plane_data_mut(&mut self, plane: u32) -> Result<&mut [u8], glib::BoolError> { if plane >= self.n_planes() { diff --git a/gstreamer-video/src/video_frame.rs b/gstreamer-video/src/video_frame.rs index bed8111cd..84ccc2366 100644 --- a/gstreamer-video/src/video_frame.rs +++ b/gstreamer-video/src/video_frame.rs @@ -474,11 +474,6 @@ impl VideoFrame { } } - #[inline] - pub fn buffer_mut(&mut self) -> &mut gst::BufferRef { - unsafe { gst::BufferRef::from_mut_ptr(self.frame.buffer) } - } - pub fn comp_data_mut(&mut self, component: u32) -> Result<&mut [u8], glib::BoolError> { let poffset = self.info().comp_poffset(component as u8) as usize; Ok(&mut self.plane_data_mut(self.format_info().plane()[component as usize])?[poffset..]) @@ -847,11 +842,6 @@ impl<'a> VideoFrameRef<&'a mut gst::BufferRef> { } } - #[inline] - pub fn buffer_mut(&mut self) -> &mut gst::BufferRef { - unsafe { gst::BufferRef::from_mut_ptr(self.frame.buffer) } - } - pub fn comp_data_mut(&mut self, component: u32) -> Result<&mut [u8], glib::BoolError> { let poffset = self.info().comp_poffset(component as u8) as usize; Ok(&mut self.plane_data_mut(self.format_info().plane()[component as usize])?[poffset..])