From 870978e286fcf8dcce63af555aa1be5c91e05f99 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= Date: Sun, 9 Feb 2020 21:22:04 +0200 Subject: [PATCH] base/base_transform: Fix minor clippy warning warning: called `map(f)` on an Option value where `f` is a unit closure --> gstreamer-base/src/subclass/base_transform.rs:683:13 | 683 | / (*parent_class) 684 | | .before_transform 685 | | .map(|f| f(element.to_glib_none().0, inbuf.as_ptr() as *mut _)); | |_______________________________________________________________________________^ | = note: `#[warn(clippy::option_map_unit_fn)]` on by default = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn --- gstreamer-base/src/subclass/base_transform.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gstreamer-base/src/subclass/base_transform.rs b/gstreamer-base/src/subclass/base_transform.rs index a5a5facf9..c364950f5 100644 --- a/gstreamer-base/src/subclass/base_transform.rs +++ b/gstreamer-base/src/subclass/base_transform.rs @@ -680,9 +680,9 @@ impl BaseTransformImplExt for T { let data = self.get_type_data(); let parent_class = data.as_ref().get_parent_class() as *mut gst_base_sys::GstBaseTransformClass; - (*parent_class) - .before_transform - .map(|f| f(element.to_glib_none().0, inbuf.as_ptr() as *mut _)); + if let Some(ref f) = (*parent_class).before_transform { + f(element.to_glib_none().0, inbuf.as_ptr() as *mut _); + } } }