From 81aba1b8a257c884f8c4bf1959e70f5aa339db63 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Fri, 10 Jul 2020 15:10:42 +0300
Subject: [PATCH] gstreamer/ghost_pad: Add convenience constructors with target
 pad

Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/issues/275
---
 gstreamer/src/ghost_pad.rs | 26 +++++++++++++++++++++++++-
 1 file changed, 25 insertions(+), 1 deletion(-)

diff --git a/gstreamer/src/ghost_pad.rs b/gstreamer/src/ghost_pad.rs
index a4bd78c68..22ef16170 100644
--- a/gstreamer/src/ghost_pad.rs
+++ b/gstreamer/src/ghost_pad.rs
@@ -16,6 +16,7 @@ use LoggableError;
 use Object;
 use Pad;
 use PadBuilder;
+use PadExt;
 use PadExtManual;
 use PadFlags;
 use PadGetRangeSuccess;
@@ -98,6 +99,30 @@ impl GhostPad {
         skip_assert_initialized!();
         PadBuilder::from_template(templ, name)
     }
+
+    pub fn with_target<P: IsA<Pad>>(
+        name: Option<&str>,
+        target: &P,
+    ) -> Result<Self, glib::BoolError> {
+        skip_assert_initialized!();
+        Self::builder(name, target.get_direction()).build_with_target(target)
+    }
+
+    pub fn from_template_with_target<P: IsA<Pad>>(
+        templ: &::PadTemplate,
+        name: Option<&str>,
+        target: &P,
+    ) -> Result<Self, glib::BoolError> {
+        skip_assert_initialized!();
+
+        if target.get_direction() != templ.get_property_direction() {
+            return Err(glib_bool_error!(
+                "Template and target have different directions"
+            ));
+        }
+
+        Self::builder_with_template(templ, name).build_with_target(target)
+    }
 }
 
 impl<T: IsA<GhostPad> + IsA<Pad>> PadBuilder<T> {
@@ -340,7 +365,6 @@ impl<T: IsA<GhostPad> + IsA<Pad>> PadBuilder<T> {
 
     pub fn build_with_target<P: IsA<Pad>>(self, target: &P) -> Result<T, glib::BoolError> {
         use GhostPadExt;
-        use PadExt;
 
         assert_eq!(self.0.get_direction(), target.get_direction());