From 5623fd18aa5456bd2c6cc85651a91a84c433e011 Mon Sep 17 00:00:00 2001 From: Jordan Petridis Date: Tue, 13 Aug 2024 15:43:09 +0300 Subject: [PATCH] ci: Add comments to the windows dockerfile about build-args Part-of: --- ci/windows-docker/Dockerfile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ci/windows-docker/Dockerfile b/ci/windows-docker/Dockerfile index 00b27da61..9d3379882 100644 --- a/ci/windows-docker/Dockerfile +++ b/ci/windows-docker/Dockerfile @@ -4,7 +4,10 @@ FROM "registry.freedesktop.org/gstreamer/gstreamer/amd64/windows:2023-07-17.0-ma SHELL ["powershell", "-Command", "$ErrorActionPreference = 'Stop'; $ProgressPreference = 'SilentlyContinue';"] -ARG DEFAULT_BRANCH="1.24" +# These arguments are always required to be specified with --build-arg +# when building the image. +# See DOCKER_BUILD_ARGS in .gitlab-ci.yml for an example +ARG DEFAULT_BRANCH="invalid" ARG RUST_VERSION="invalid" RUN choco install -y pkgconfiglite nasm llvm openssl