From f4b086738b768f8ea5357a6d557f87ceaac2ce90 Mon Sep 17 00:00:00 2001 From: Taruntej Kanakamalla Date: Fri, 5 Apr 2024 17:12:55 +0530 Subject: [PATCH] webrtcsrc: change the producer-id type for request-encoded-filter With https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/1477 the producer id used while emitting the request-encoded-filter can be a None if the msid of the webrtcbin's pad is None. This might not affect the signal handler written in C but can panic in an existing Rust application with signal handler which can only handle valid String type as its param for the producer id. So change the param type to Option in the signal builder for request-encoded-fiter signal Part-of: --- net/webrtc/src/webrtcsrc/imp.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/webrtc/src/webrtcsrc/imp.rs b/net/webrtc/src/webrtcsrc/imp.rs index 6923a99a..b779facf 100644 --- a/net/webrtc/src/webrtcsrc/imp.rs +++ b/net/webrtc/src/webrtcsrc/imp.rs @@ -240,7 +240,7 @@ impl ObjectImpl for BaseWebRTCSrc { */ glib::subclass::Signal::builder("request-encoded-filter") .param_types([ - String::static_type(), + Option::::static_type(), String::static_type(), Option::::static_type(), ])