From e7c0485e8c6f864bdad92b9500ca35f58c49319d Mon Sep 17 00:00:00 2001
From: Philippe Normand <philn@igalia.com>
Date: Mon, 9 Jun 2025 09:48:23 +0100
Subject: [PATCH] pcap_writer: Make target-property and pad-path properties
 writable again

The warning reported in
https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2031#note_2874920
is no longer emitted.

This reverts commit 6f7a1e21d5cd8e12ed216808054e6fca0c584700.

Part-of: <https://gitlab.freedesktop.org/gstreamer/gst-plugins-rs/-/merge_requests/2281>
---
 docs/plugins/gst_plugins_cache.json  | 4 ++--
 utils/tracers/src/pcap_writer/imp.rs | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/docs/plugins/gst_plugins_cache.json b/docs/plugins/gst_plugins_cache.json
index cbeebe18a..80a3a297e 100644
--- a/docs/plugins/gst_plugins_cache.json
+++ b/docs/plugins/gst_plugins_cache.json
@@ -12756,7 +12756,7 @@
                         "blurb": "Pad path to target",
                         "conditionally-available": false,
                         "construct": false,
-                        "construct-only": true,
+                        "construct-only": false,
                         "controllable": false,
                         "default": "NULL",
                         "mutable": "null",
@@ -12768,7 +12768,7 @@
                         "blurb": "Factory name to target",
                         "conditionally-available": false,
                         "construct": false,
-                        "construct-only": true,
+                        "construct-only": false,
                         "controllable": false,
                         "default": "NULL",
                         "mutable": "null",
diff --git a/utils/tracers/src/pcap_writer/imp.rs b/utils/tracers/src/pcap_writer/imp.rs
index 5c7aabb49..4f5ad1ef4 100644
--- a/utils/tracers/src/pcap_writer/imp.rs
+++ b/utils/tracers/src/pcap_writer/imp.rs
@@ -171,7 +171,6 @@ pub struct PcapWriter {
         name="target-factory",
         get,
         set,
-        construct_only,
         type = Option<String>,
         member = target_factory,
         blurb = "Factory name to target")
@@ -180,7 +179,6 @@ pub struct PcapWriter {
         name="pad-path",
         get,
         set,
-        construct_only,
         type = Option<String>,
         member = pad_path,
         blurb = "Pad path to target")