From da21dc853dff3f8a0209223e29b82e39edb37cb0 Mon Sep 17 00:00:00 2001 From: Maksym Khomenko Date: Tue, 20 Feb 2024 19:29:46 +0200 Subject: [PATCH] webrtcsink: extensions: separate API and signal checks Part-of: --- net/webrtc/src/webrtcsink/imp.rs | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/net/webrtc/src/webrtcsink/imp.rs b/net/webrtc/src/webrtcsink/imp.rs index 02444b0d..f3321269 100644 --- a/net/webrtc/src/webrtcsink/imp.rs +++ b/net/webrtc/src/webrtcsink/imp.rs @@ -1543,12 +1543,13 @@ impl BaseWebRTCSink { match extension_configuration_type { ExtensionConfigurationType::Auto => { // GstRTPBasePayload::extensions property is only available since GStreamer 1.24 - if !payloader.has_property("extensions", Some(gst::Array::static_type())) - && self.has_connected_payloader_setup_slots() - { - gst::warning!(CAT, "'extensions' property is not available: TWCC extension ID will default to 1. \ + if !payloader.has_property("extensions", Some(gst::Array::static_type())) { + if self.has_connected_payloader_setup_slots() { + gst::warning!(CAT, "'extensions' property is not available: TWCC extension ID will default to 1. \ Application code must ensure to pick non-conflicting IDs for any additionally configured extensions. \ Please consider updating GStreamer to 1.24."); + } + return Some(1); }